Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:notification): remove deprecated APIs for v10 #5779

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@hsuanxyz hsuanxyz requested a review from wzhudev as a code owner September 15, 2020 07:34
@hsuanxyz hsuanxyz force-pushed the chore/deprecated-notification branch from 93ce159 to 6afc2a6 Compare September 15, 2020 07:35
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #5779 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5779      +/-   ##
==========================================
+ Coverage   90.06%   90.08%   +0.01%     
==========================================
  Files         455      455              
  Lines       13856    13853       -3     
  Branches     2187     2184       -3     
==========================================
  Hits        12479    12479              
+ Misses        851      850       -1     
+ Partials      526      524       -2     
Impacted Files Coverage Δ
...s/notification/notification-container.component.ts 100.00% <100.00%> (+5.66%) ⬆️
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (-0.71%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50d530...9a212a1. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the chore/deprecated-notification branch from 6afc2a6 to 3c75457 Compare September 15, 2020 08:41
BREAKING CHANGES:

- `NzNotificationDataFilled` has been removed, use `NzNotificationRef` instead.
- `NzNotificationDataOptions.nzPosition` has been removed, use `NzNotificationDataOptions.nzPlacement` instead.
@hsuanxyz hsuanxyz force-pushed the chore/deprecated-notification branch from 3c75457 to 9a212a1 Compare September 15, 2020 09:49
@hsuanxyz hsuanxyz merged commit e5ed4d2 into NG-ZORRO:master Sep 15, 2020
@hsuanxyz hsuanxyz deleted the chore/deprecated-notification branch September 15, 2020 10:24
@github-actions
Copy link

github-actions bot commented Sep 15, 2020

😭 Deploy PR Preview e5ed4d2 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant