Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:tree): remove deprecated APIs for v10 #5789

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGES:

- `NzTreeNode.isAllChecked` has been removed, use `NzTreeNode.isChecked` instead.
- `NzTreeNode.setSelected(boolean)` has been removed, use `NzTreeNode.isSelected = boolean` instead.
@hsuanxyz hsuanxyz force-pushed the chore/deprecated-tree branch from 5f560f6 to 5e7523b Compare September 16, 2020 07:31
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #5789 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
+ Coverage   90.09%   90.13%   +0.04%     
==========================================
  Files         455      455              
  Lines       13854    13843      -11     
  Branches     2184     2184              
==========================================
- Hits        12482    12478       -4     
+ Misses        849      840       -9     
- Partials      523      525       +2     
Impacted Files Coverage Δ
components/core/tree/nz-tree-base-node.ts 67.39% <ø> (+3.24%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (-0.71%) ⬇️
components/select/select.component.ts 87.67% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7877b...5e7523b. Read the comment docs.

@hsuanxyz hsuanxyz merged commit b378cb7 into NG-ZORRO:master Sep 16, 2020
@hsuanxyz hsuanxyz deleted the chore/deprecated-tree branch September 16, 2020 08:05
@github-actions
Copy link

github-actions bot commented Sep 16, 2020

😭 Deploy PR Preview b378cb7 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant