Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:date-picker): remove deprecated APIs for v10 #5793

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 16, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #5793 into master will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5793      +/-   ##
==========================================
- Coverage   90.26%   90.25%   -0.02%     
==========================================
  Files         455      454       -1     
  Lines       13823    13787      -36     
  Branches     2180     2171       -9     
==========================================
- Hits        12477    12443      -34     
  Misses        823      823              
+ Partials      523      521       -2     
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 95.38% <ø> (-0.21%) ⬇️
components/i18n/date-config.ts 100.00% <ø> (ø)
components/i18n/date-helper.service.ts 82.35% <80.00%> (-2.65%) ⬇️
components/date-picker/testing/util.ts 77.77% <0.00%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132e425...050261a. Read the comment docs.

@wenqi73 wenqi73 requested a review from hsuanxyz as a code owner September 16, 2020 11:46
@wenqi73 wenqi73 force-pushed the update-date-picker branch 3 times, most recently from a109d09 to 59357f3 Compare September 16, 2020 12:47
BREAKING CHANGES:

- `NZ_DATE_FNS_COMPATIBLE` has been removed. Please migrate to date-fns v2 manually.
- nz-date-picker,nz-week-picker,nz-month-picker,nz-year-picker,nz-range-picker
  * [nzClassName]` has been removed, use `ngClass` instead.
  * [nzStyle]` has been removed, use `ngStyle` instead.
@hsuanxyz hsuanxyz merged commit 5159900 into NG-ZORRO:master Sep 17, 2020
@github-actions
Copy link

github-actions bot commented Sep 17, 2020

😭 Deploy PR Preview 5159900 failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants