Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): years contain disabled date cannot select #5804

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Sep 17, 2020

Fixes #5633

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #5804 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5804      +/-   ##
==========================================
+ Coverage   90.00%   90.02%   +0.02%     
==========================================
  Files         463      463              
  Lines       13925    13941      +16     
  Branches     2202     2204       +2     
==========================================
+ Hits        12533    12551      +18     
+ Misses        859      855       -4     
- Partials      533      535       +2     
Impacted Files Coverage Δ
components/date-picker/inner-popup.component.ts 86.95% <ø> (ø)
...omponents/date-picker/lib/month-table.component.ts 88.13% <100.00%> (+1.86%) ⬆️
components/date-picker/lib/year-table.component.ts 89.55% <100.00%> (+1.41%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/modal/modal-ref.ts 97.84% <0.00%> (ø)
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89aaa79...c6e1420. Read the comment docs.

@wenqi73 wenqi73 requested a review from hsuanxyz October 9, 2020 06:35
@wenqi73 wenqi73 force-pushed the cell-disabled branch 3 times, most recently from 0843361 to 70bd70b Compare October 9, 2020 09:26
@hsuanxyz hsuanxyz merged commit 3ba0366 into NG-ZORRO:master Oct 9, 2020
@github-actions
Copy link

github-actions bot commented Oct 9, 2020

😭 Deploy PR Preview 3ba0366 failed. Build logs

🤖 By surge-preview

@wenqi73 wenqi73 deleted the cell-disabled branch October 9, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

date-picker: years that contain disabled dates cannot be selected
2 participants