Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tooltip): add nzTooltipColor #5896

Merged
merged 3 commits into from
Oct 23, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 11, 2020

close #5884

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #5896 into master will decrease coverage by 0.02%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5896      +/-   ##
==========================================
- Coverage   90.00%   89.98%   -0.03%     
==========================================
  Files         463      464       +1     
  Lines       13986    13998      +12     
  Branches     2297     2299       +2     
==========================================
+ Hits        12588    12596       +8     
- Misses        854      857       +3     
- Partials      544      545       +1     
Impacted Files Coverage Δ
components/tooltip/base.ts 91.00% <80.00%> (-0.96%) ⬇️
components/core/color/color.ts 100.00% <100.00%> (ø)
components/tag/tag.component.ts 100.00% <100.00%> (ø)
components/tooltip/tooltip.ts 100.00% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846331e...7a723b7. Read the comment docs.

@wzhudev wzhudev changed the title Feat/tooltip background feat(module:tooltip): add nzTooltipColor Oct 11, 2020
@wzhudev wzhudev marked this pull request as draft October 11, 2020 07:24
@wzhudev wzhudev self-assigned this Oct 13, 2020
@wzhudev wzhudev marked this pull request as ready for review October 13, 2020 11:34
@wzhudev wzhudev force-pushed the feat/tooltip-background branch from b2412ef to 18ce6e7 Compare October 13, 2020 11:44
@hsuanxyz
Copy link
Member

@wendellhu95 rebase

@wzhudev
Copy link
Member Author

wzhudev commented Oct 23, 2020

@wendellhu95 rebase

Will do, sir. 💯

wendellhu95 added 3 commits October 23, 2020 18:45
@wzhudev wzhudev force-pushed the feat/tooltip-background branch from 8b37fa7 to 7a723b7 Compare October 23, 2020 10:46
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 643bd03 into NG-ZORRO:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tooltip] support color background
2 participants