Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): add nzBorderless #5975

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Oct 26, 2020

close #5680

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 26, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #5975 into master will decrease coverage by 0.02%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5975      +/-   ##
==========================================
- Coverage   89.96%   89.93%   -0.03%     
==========================================
  Files         465      465              
  Lines       14047    14044       -3     
  Branches     2311     2308       -3     
==========================================
- Hits        12637    12631       -6     
- Misses        859      866       +7     
+ Partials      551      547       -4     
Impacted Files Coverage Δ
components/date-picker/inner-popup.component.ts 86.95% <ø> (ø)
components/date-picker/lib/abstract-table.ts 89.58% <ø> (ø)
components/date-picker/picker.component.ts 89.47% <88.88%> (-1.10%) ⬇️
components/date-picker/date-picker.component.ts 92.30% <100.00%> (-0.06%) ⬇️
...mponents/date-picker/date-range-popup.component.ts 91.86% <100.00%> (+0.14%) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0.00%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/select/select.component.ts 87.54% <0.00%> (+0.42%) ⬆️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+0.70%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2125f9f...5ef3f00. Read the comment docs.

@wenqi73 wenqi73 force-pushed the date-picker/no-border branch from d45758e to 5ef3f00 Compare October 26, 2020 09:49
@wenqi73 wenqi73 requested a review from hsuanxyz October 26, 2020 11:11
@hsuanxyz hsuanxyz merged commit 25e41fa into NG-ZORRO:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker open and close quickly error
2 participants