Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:breadcrumb): patch last-child's style indule a is included #5994

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
close #5942

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 31, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #5994 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5994   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         465      465           
  Lines       14044    14044           
  Branches     2307     2307           
=======================================
+ Hits        12630    12631    +1     
- Misses        865      866    +1     
+ Partials      549      547    -2     
Impacted Files Coverage Δ
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36e22c...da2270c. Read the comment docs.

components/breadcrumb/style/patch.less Outdated Show resolved Hide resolved
Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stygian-desolator !

@wenqi73 wenqi73 changed the title fix(module:breadcrumb): patch last-child's style when 'a' is included fix(module:breadcrumb): patch last-child's style indule a is included Nov 2, 2020
@wenqi73 wenqi73 merged commit 50f0744 into NG-ZORRO:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb <a></a> tag's style is overiding breadcrumb last-child's style
3 participants