Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): sync class name with ant-design #6030

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix(module:cascader): sync class name with ant-design #6030

merged 1 commit into from
Nov 9, 2020

Conversation

rppig42
Copy link
Contributor

@rppig42 rppig42 commented Nov 9, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

when Cascader search bar is not empty and focused, the font color is pure black

Issue Number: #6020

What is the new behavior?

when Cascader search bar is not empty and focused, the font color is gray

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Due to the lack of experience of git collaboration, I ruined the old pull request #6021. I've opened another pr, @hsuanxyz pls take a look.

This pr synced the class name to be consistent with ant design so that the styles from ant-design would take effect.

@rppig42 rppig42 requested a review from wzhudev as a code owner November 9, 2020 07:38
@zorro-bot
Copy link

zorro-bot bot commented Nov 9, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #6030 (65d8492) into master (22aea7e) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6030      +/-   ##
==========================================
+ Coverage   89.91%   89.95%   +0.04%     
==========================================
  Files         465      465              
  Lines       14042    14042              
  Branches     2307     2307              
==========================================
+ Hits        12626    12632       +6     
+ Misses        869      863       -6     
  Partials      547      547              
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 94.67% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (+0.70%) ⬆️
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22aea7e...65d8492. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 9c4424f into NG-ZORRO:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants