Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include missing language exports #6061

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

vytautas-petrikas
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Not all i18N language files are included in the public_api.ts file, which leads to missing type definition files in the final package.

Issue Number: N/A

What is the new behavior?

All i18N language files are included in the public_api.ts.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Let me know what needs to be changed in order to release this.

@zorro-bot
Copy link

zorro-bot bot commented Nov 16, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #6061 (6d0869d) into master (fb4cc91) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6061      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.02%     
==========================================
  Files         465      465              
  Lines       14057    14057              
  Branches     2311     2311              
==========================================
- Hits        12633    12631       -2     
- Misses        877      879       +2     
  Partials      547      547              
Impacted Files Coverage Δ
components/tabs/tab-nav-bar.component.ts 80.91% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb4cc91...6d0869d. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job!

@hsuanxyz hsuanxyz merged commit 6543a80 into NG-ZORRO:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants