Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:steps): step supports enable and disable #6101

Merged

Conversation

stygian-desolator
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

close #5579

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #6101 (7da2e82) into master (1d7964e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6101      +/-   ##
==========================================
+ Coverage   89.82%   89.88%   +0.05%     
==========================================
  Files         465      465              
  Lines       14095    14101       +6     
  Branches     2236     2236              
==========================================
+ Hits        12661    12674      +13     
+ Misses        882      873       -9     
- Partials      552      554       +2     
Impacted Files Coverage Δ
components/steps/step.component.ts 97.72% <100.00%> (+0.35%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/table/src/table-style.service.ts 94.82% <0.00%> (-1.73%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (+0.70%) ⬆️
components/table/src/table-data.service.ts 84.61% <0.00%> (+6.15%) ⬆️
components/table/src/table/tr-measure.component.ts 100.00% <0.00%> (+13.63%) ⬆️
components/table/src/table/tbody.component.ts 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7964e...7da2e82. Read the comment docs.

@hsuanxyz hsuanxyz merged commit b87e72d into NG-ZORRO:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-steps: incorrect mouse pointer and click behavior for enabled and disabled steps
2 participants