Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): index only changed by router event when nzLinkRouter #6293

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

yangjunhan
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@yangjunhan yangjunhan requested a review from NearZXH as a code owner December 31, 2020 03:25
@zorro-bot
Copy link

zorro-bot bot commented Dec 31, 2020

This preview will be available after the AzureCI is passed.

@yangjunhan yangjunhan requested review from hsuanxyz and removed request for NearZXH December 31, 2020 03:26
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #6293 (6468b5c) into master (0694079) will increase coverage by 0.08%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6293      +/-   ##
==========================================
+ Coverage   89.80%   89.89%   +0.08%     
==========================================
  Files         477      478       +1     
  Lines       15186    15245      +59     
  Branches     2298     2316      +18     
==========================================
+ Hits        13638    13704      +66     
+ Misses        949      930      -19     
- Partials      599      611      +12     
Impacted Files Coverage Δ
components/tabs/tab-link.directive.ts 42.85% <0.00%> (-7.15%) ⬇️
components/tabs/tabset.component.ts 89.47% <75.00%> (+5.68%) ⬆️
components/core/services/scroll.ts 81.96% <0.00%> (-1.64%) ⬇️
components/modal/modal-container.ts 92.30% <0.00%> (-0.80%) ⬇️
components/collapse/collapse.module.ts 100.00% <0.00%> (ø)
components/image/utils.ts 89.65% <0.00%> (ø)
components/collapse/collapse-panel.component.ts 93.10% <0.00%> (+0.24%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (+0.70%) ⬆️
components/image/image-preview.component.ts 90.13% <0.00%> (+2.27%) ⬆️
components/tabs/tabs-ink-bar.directive.ts 87.09% <0.00%> (+3.22%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0694079...6468b5c. Read the comment docs.

@yangjunhan yangjunhan force-pushed the tabs-router-click branch 2 times, most recently from 5f36eac to 2742152 Compare December 31, 2020 07:52
@yangjunhan yangjunhan changed the title fix(module:tabs): link router does not match active tab fix(module:tabs): selectedIndex changes by router link click event Dec 31, 2020
@yangjunhan yangjunhan force-pushed the tabs-router-click branch 2 times, most recently from 13ebd4d to a1dfde4 Compare December 31, 2020 07:58
@yangjunhan yangjunhan changed the title fix(module:tabs): selectedIndex changes by router link click event fix(module:tabs): selectedIndex should only be changed by router event Dec 31, 2020
@yangjunhan yangjunhan changed the title fix(module:tabs): selectedIndex should only be changed by router event fix(module:tabs): index only changed by router event when nzLinkRouter Dec 31, 2020
@wenqi73 wenqi73 merged commit ca1b861 into NG-ZORRO:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants