Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): add nzCentered for modal #6333

Merged
merged 4 commits into from
Jan 22, 2021

Conversation

lsbbd
Copy link
Contributor

@lsbbd lsbbd commented Jan 11, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[x] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6327

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@lsbbd lsbbd requested a review from hsuanxyz as a code owner January 11, 2021 14:49
@zorro-bot
Copy link

zorro-bot bot commented Jan 11, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #6333 (e07404c) into master (caad718) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6333   +/-   ##
=======================================
  Coverage   89.90%   89.91%           
=======================================
  Files         478      478           
  Lines       15250    15252    +2     
  Branches     2318     2318           
=======================================
+ Hits        13711    13714    +3     
+ Misses        926      924    -2     
- Partials      613      614    +1     
Impacted Files Coverage Δ
...ponents/modal/modal-confirm-container.component.ts 100.00% <ø> (ø)
components/modal/modal-container.component.ts 100.00% <ø> (ø)
components/modal/utils.ts 100.00% <ø> (ø)
components/modal/modal-types.ts 100.00% <100.00%> (ø)
components/modal/modal.component.ts 92.94% <100.00%> (+0.08%) ⬆️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (+1.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caad718...e07404c. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 8fd4df6 into NG-ZORRO:master Jan 22, 2021
@lsbbd lsbbd mentioned this pull request Jan 22, 2021
3 tasks
ZhWent pushed a commit to ZhWent/ng-zorro-antd that referenced this pull request Mar 3, 2021
* upsteam/master:
  fix(schematics): fix `add-icon-assets`  schema path (NG-ZORRO#6404)
  fix(module:tree-view): correct API typo (NG-ZORRO#6386)
  chore(release): release 11.1.0 (NG-ZORRO#6371)
  fix(module:table): fix table `nzBordered` (NG-ZORRO#6367)
  fix(module:typography): edit area cannot get the content (NG-ZORRO#6369)
  feat(module:table): add support for ReadonlyArray (NG-ZORRO#6156)
  build: update to 11.1 (NG-ZORRO#6365)
  chore: sync ant-design v4.10.3 (NG-ZORRO#6364)
  feat(module:table): support nzPaginationType property (NG-ZORRO#5986)
  feat(module:date-picker): support nzId (NG-ZORRO#6242) (NG-ZORRO#6246)
  feat(module:upload): support `NzUploadFile` parameter of `nzIconRender` (NG-ZORRO#6283)
  feat(module:modal): add nzCentered for modal (NG-ZORRO#6333)
  chore: sync ant-design v4.10.2 (NG-ZORRO#6334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants