Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:rate): fix invalid type of nzCount in strictTemplates #6457

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Feb 26, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk cipchk requested a review from wzhudev as a code owner February 26, 2021 11:43
@zorro-bot
Copy link

zorro-bot bot commented Feb 26, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #6457 (5077d3d) into master (ec03c7f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6457   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         478      478           
  Lines       15314    15314           
  Branches     2475     2475           
=======================================
  Hits        13756    13756           
  Misses        940      940           
  Partials      618      618           
Impacted Files Coverage Δ
components/rate/rate.component.ts 96.03% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec03c7f...6b7772f. Read the comment docs.

@wzhudev
Copy link
Member

wzhudev commented Feb 28, 2021

LGTM

@hsuanxyz hsuanxyz merged commit 4d28a60 into NG-ZORRO:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants