Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:checkbox): add nzId input #6813

Merged

Conversation

konossow
Copy link
Contributor

@konossow konossow commented Jul 1, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #6801

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

@konossow konossow requested a review from vthinkxie as a code owner July 1, 2021 07:34
@zorro-bot
Copy link

zorro-bot bot commented Jul 1, 2021

This preview will be available after the AzureCI is passed.

@konossow konossow force-pushed the feature/6801_nzCheckbox_nzId_input branch from ef900d9 to a3862d5 Compare July 1, 2021 07:36
@konossow konossow changed the title Feature/6801 nz checkbox nz id input feat(module:checkbox): add nzId input Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #6813 (99c9833) into master (ca2d3eb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 99c9833 differs from pull request most recent head 378a26c. Consider uploading reports for the commit 378a26c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6813      +/-   ##
==========================================
- Coverage   89.56%   89.55%   -0.02%     
==========================================
  Files         488      488              
  Lines       15779    15780       +1     
  Branches     2423     2423              
==========================================
- Hits        14133    14132       -1     
- Misses       1005     1006       +1     
- Partials      641      642       +1     
Impacted Files Coverage Δ
components/checkbox/checkbox.component.ts 96.92% <100.00%> (+0.04%) ⬆️
components/tabs/tab-nav-bar.component.ts 82.33% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca2d3eb...378a26c. Read the comment docs.

@konossow konossow force-pushed the feature/6801_nzCheckbox_nzId_input branch from a3862d5 to 378a26c Compare July 1, 2021 07:46
@konossow konossow mentioned this pull request Jul 1, 2021
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 52235c9 into NG-ZORRO:master Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants