fix(module:upload): do not trigger change detection for nz-upload-btn
#7032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, it runs change detection each time the
nz-upload-btn
is clicked, tho it opens a native OS file picker. This is considered as a "dead" change detection (ApplicationRef.tick()
is run, but there's nothing to update). This may cause a frame drop when opening a native file picker (because Angular has to run the whole change detection before opening it).What is the new behavior?
There's no dead change detection when the
nz-upload-btn
is clicked.Does this PR introduce a breaking change?