Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [nzPopconfirmContext] support to nz-popconfirm #7606

Closed
crossan007 opened this issue Aug 10, 2022 · 2 comments
Closed

Add [nzPopconfirmContext] support to nz-popconfirm #7606

crossan007 opened this issue Aug 10, 2022 · 2 comments
Assignees
Labels
👌 Already Fixed There is already a PR trying to solve this Component: Popconfirm help wanted

Comments

@crossan007
Copy link

What problem does this feature solve?

I'd like to re-use a <ng-template #templateRef> between multiple instances of nz-popconfirm but need to have access to context variables like those produced by *ngFor.

Presently, the nzPopconfirmTitle attribute only allows string | TemplateRef<void>, but I would like to supply string | TemplateRef<any> and pass in additional context to the template

This is nearly identical to the feature request #6607 but for the nz-popconfirm component instead of the nz-tooltip component

What does the proposed API look like?

An additional property is available on html tags having nz-popconfirm which allows passing template context into the template defined by nzPopconfirmTitle

@crossan007
Copy link
Author

Also relates to #4706

@zorro-bot
Copy link

zorro-bot bot commented Aug 11, 2022

Hello @crossan007. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @crossan007, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

@Laffery Laffery added the 👌 Already Fixed There is already a PR trying to solve this label Jul 15, 2024
@Laffery Laffery closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👌 Already Fixed There is already a PR trying to solve this Component: Popconfirm help wanted
Projects
None yet
Development

No branches or pull requests

3 participants