Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): cell title should reflect nzFormat #8744

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

RubenVermeulen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #8743

What is the new behavior?

The cell title of the date picker reflects nzFormat instead of relying on the locale setting.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 11, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.90%. Comparing base (b382b58) to head (f8ab118).
Report is 139 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8744      +/-   ##
==========================================
- Coverage   93.15%   91.90%   -1.25%     
==========================================
  Files         538      555      +17     
  Lines       18456    19708    +1252     
  Branches     2816     2943     +127     
==========================================
+ Hits        17192    18113     +921     
- Misses       1226     1268      +42     
- Partials       38      327     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 1b7ab5a into NG-ZORRO:master Dec 21, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants