Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:avatar): calculate size at the right time #8754

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

HyperLife1119
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

当 文字类型的头像 在像 dropdown 这种 overlay 组件中渲染时,无法正确计算文本尺寸:
image

What is the new behavior?

通过使用 afterRender 来确保可以正确 读/写 DOM 来解决该问题:
image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Sep 16, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (c64e1a1) to head (aba6f8e).
Report is 86 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8754      +/-   ##
==========================================
+ Coverage   91.67%   93.15%   +1.47%     
==========================================
  Files         538      538              
  Lines       18457    18455       -2     
  Branches     2816     2816              
==========================================
+ Hits        16920    17191     +271     
- Misses       1225     1226       +1     
+ Partials      312       38     -274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Laffery Laffery added this to the v19 milestone Nov 19, 2024
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 3a5ba37 into NG-ZORRO:master Nov 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants