-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:carousel): carousel not working correctly in rtl mode #8770
fix(module:carousel): carousel not working correctly in rtl mode #8770
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8770 +/- ##
=======================================
Coverage 93.15% 93.15%
=======================================
Files 538 538
Lines 18457 18453 -4
Branches 2816 2815 -1
=======================================
- Hits 17193 17190 -3
+ Misses 1226 1225 -1
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…viour-in-rtl-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job and LGTM !
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In RTL mode, there are some issues with the Carousel component.
For some weird resone, when you change the direction of the document side to RTL, the
directionality.change
is not emitted; so in the document site you can not see the bugs, This is a recording of the produced bug in the RTL mode.Carousel-bug.mp4
What is the new behavior?
The footage for the fixed behavior in the RTL mode:
Carousel-fixed.mp4
Does this PR introduce a breaking change?
Other information
🔶 NOTES:
onLiClick
is not required any more.[dir]="'ltr'"
and didn't put it in the style files becase Ant also gives it as an inline attribute on the HTML: