diff --git a/components/dropdown/dropdown-menu.component.ts b/components/dropdown/dropdown-menu.component.ts
index 312d8fb4413..e6393acb00f 100644
--- a/components/dropdown/dropdown-menu.component.ts
+++ b/components/dropdown/dropdown-menu.component.ts
@@ -46,6 +46,7 @@ export type NzPlacementType = 'bottomLeft' | 'bottomCenter' | 'bottomRight' | 't
         [@slideMotion]="'enter'"
         [@.disabled]="noAnimation?.nzNoAnimation"
         [nzNoAnimation]="noAnimation?.nzNoAnimation"
+        [attr.id]="id"
         (mouseenter)="setMouseState(true)"
         (mouseleave)="setMouseState(false)"
       >
@@ -63,6 +64,7 @@ export class NzDropdownMenuComponent implements AfterContentInit {
   descendantMenuItemClick$ = this.nzMenuService.descendantMenuItemClick$;
   nzOverlayClassName: string = '';
   nzOverlayStyle: IndexableObject = {};
+  id: string | null = null;
   @ViewChild(TemplateRef, { static: true }) templateRef!: TemplateRef<NzSafeAny>;
 
   setMouseState(visible: boolean): void {
diff --git a/components/dropdown/dropdown.directive.spec.ts b/components/dropdown/dropdown.directive.spec.ts
index addce04db67..e3f72d56015 100644
--- a/components/dropdown/dropdown.directive.spec.ts
+++ b/components/dropdown/dropdown.directive.spec.ts
@@ -197,6 +197,27 @@ describe('dropdown', () => {
     fixture.detectChanges();
     expect(fixture.componentInstance.triggerVisible).toHaveBeenCalledTimes(1);
   }));
+  it('should aria states work', fakeAsync(() => {
+    const fixture = createComponent(NzTestDropdownComponent, [], []);
+    fixture.componentInstance.trigger = 'click';
+
+    fixture.detectChanges();
+    const dropdownElement = fixture.debugElement.query(By.directive(NzDropDownDirective)).nativeElement;
+
+    expect(dropdownElement.getAttribute('aria-haspopup')).toBe('menu');
+    expect(dropdownElement.getAttribute('aria-expanded')).toBe('false');
+    expect(dropdownElement.getAttribute('aria-owns')).toBe(null);
+
+    dispatchFakeEvent(dropdownElement, 'click');
+    tick(1000);
+    fixture.detectChanges();
+
+    const overlayMenu = overlayContainerElement.querySelector('.ant-dropdown')!;
+    expect(dropdownElement.getAttribute('aria-expanded')).toBe('true');
+    const id = dropdownElement.getAttribute('aria-owns');
+    expect(id).not.toBe(null);
+    expect(overlayMenu.getAttribute('id')).toBe(id);
+  }));
 });
 
 @Component({
@@ -210,7 +231,8 @@ describe('dropdown', () => {
       [nzBackdrop]="backdrop"
       [nzOverlayClassName]="className"
       [nzOverlayStyle]="overlayStyle"
-      >Trigger
+    >
+      Trigger
     </a>
     <nz-dropdown-menu #menu="nzDropdownMenu">
       <ul nz-menu>
@@ -232,9 +254,9 @@ export class NzTestDropdownComponent {
 
 @Component({
   template: `
-    <a nz-dropdown [nzDropdownMenu]="menu" [nzClickHide]="false" [(nzVisible)]="visible" (nzVisibleChange)="triggerVisible($event)"
-      >Hover me</a
-    >
+    <a nz-dropdown [nzDropdownMenu]="menu" [nzClickHide]="false" [(nzVisible)]="visible" (nzVisibleChange)="triggerVisible($event)">
+      Hover me
+    </a>
     <nz-dropdown-menu #menu="nzDropdownMenu">
       <ul nz-menu>
         <li nz-menu-item class="first-menu">Clicking me will not close the menu.</li>
diff --git a/components/dropdown/dropdown.directive.ts b/components/dropdown/dropdown.directive.ts
index e35bd6741c5..6c788864ed8 100644
--- a/components/dropdown/dropdown.directive.ts
+++ b/components/dropdown/dropdown.directive.ts
@@ -29,12 +29,16 @@ import { auditTime, distinctUntilChanged, filter, map, mapTo, switchMap, takeUnt
 import { NzDropdownMenuComponent, NzPlacementType } from './dropdown-menu.component';
 
 const listOfPositions = [POSITION_MAP.bottomLeft, POSITION_MAP.bottomRight, POSITION_MAP.topRight, POSITION_MAP.topLeft];
+let dropdowns = 0;
 
 @Directive({
   selector: '[nz-dropdown]',
   exportAs: 'nzDropdown',
   host: {
-    '[class.ant-dropdown-trigger]': 'true'
+    '[class.ant-dropdown-trigger]': 'true',
+    '[attr.aria-owns]': 'nzVisible? dropdownId:null',
+    '[attr.aria-expanded]': 'nzVisible',
+    'aria-haspopup': 'menu'
   }
 })
 export class NzDropDownDirective implements AfterViewInit, OnDestroy, OnChanges, OnInit {
@@ -65,6 +69,7 @@ export class NzDropDownDirective implements AfterViewInit, OnDestroy, OnChanges,
   @Input() nzOverlayStyle: IndexableObject = {};
   @Input() nzPlacement: NzPlacementType = 'bottomLeft';
   @Output() readonly nzVisibleChange: EventEmitter<boolean> = new EventEmitter();
+  dropdownId: string | null = null;
 
   setDropdownMenuValue<T extends keyof NzDropdownMenuComponent>(key: T, value: NzDropdownMenuComponent[T]): void {
     if (this.nzDropdownMenu) {
@@ -134,6 +139,10 @@ export class NzDropDownDirective implements AfterViewInit, OnDestroy, OnChanges,
           if (visible) {
             /** set up overlayRef **/
             if (!this.overlayRef) {
+              if (this.nzDropdownMenu) {
+                this.dropdownId = `dropdown-${dropdowns++}`;
+                this.nzDropdownMenu.id = this.dropdownId;
+              }
               /** new overlay **/
               this.overlayRef = this.overlay.create({
                 positionStrategy: this.positionStrategy,
diff --git a/components/icon/icon.directive.ts b/components/icon/icon.directive.ts
index 8a1f6d6bcaa..f8c43006a99 100644
--- a/components/icon/icon.directive.ts
+++ b/components/icon/icon.directive.ts
@@ -81,6 +81,7 @@ export class NzIconDirective extends IconDirective implements OnInit, OnChanges,
 
   ngOnInit(): void {
     this.renderer.setAttribute(this.el, 'class', `anticon ${this.el.className}`.trim());
+    this.renderer.setAttribute(this.el, 'role', 'img');
   }
 
   /**
@@ -105,6 +106,7 @@ export class NzIconDirective extends IconDirective implements OnInit, OnChanges,
    * Replacement of `changeIcon` for more modifications.
    */
   private changeIcon2(): void {
+    this.setAriaLabel();
     this.setClassName();
     this._changeIcon().then(svgOrRemove => {
       if (svgOrRemove) {
@@ -131,6 +133,10 @@ export class NzIconDirective extends IconDirective implements OnInit, OnChanges,
     }
   }
 
+  private setAriaLabel(): void {
+    this.renderer.setAttribute(this.el, 'aria-label', this.type as string);
+  }
+
   private setClassName(): void {
     if (this.cacheClassName) {
       this.renderer.removeClass(this.el, this.cacheClassName);
diff --git a/components/icon/icon.spec.ts b/components/icon/icon.spec.ts
index cfc5d6ba6f3..8d15b9575f5 100644
--- a/components/icon/icon.spec.ts
+++ b/components/icon/icon.spec.ts
@@ -56,6 +56,21 @@ describe('nz-icon', () => {
       expect(icons[0].nativeElement.classList.contains('anticon-question')).not.toBe(true);
     });
 
+    it('should get icon aria label back', () => {
+      fixture.detectChanges();
+      expect(icons[0].nativeElement.getAttribute('role')).toBe('img');
+      expect(icons[0].nativeElement.getAttribute('aria-label')).toBe('question');
+      expect(icons[1].nativeElement.getAttribute('aria-label')).toBe('loading');
+    });
+
+    it('should change aria label when type changes', () => {
+      testComponent.type = 'question-circle';
+      fixture.detectChanges();
+      expect(icons[0].nativeElement.getAttribute('role')).toBe('img');
+      expect(icons[0].nativeElement.getAttribute('aria-label')).toBe('question-circle');
+      expect(icons[0].nativeElement.getAttribute('aria-label')).not.toBe('question');
+    });
+
     it('should support spin and cancel', fakeAsync(() => {
       fixture.detectChanges();
       tick(1000);
diff --git a/components/input-number/input-number.component.ts b/components/input-number/input-number.component.ts
index 165b4e5bac2..ae7d6f2eda5 100644
--- a/components/input-number/input-number.component.ts
+++ b/components/input-number/input-number.component.ts
@@ -33,22 +33,28 @@ import { InputBoolean, isNotNil } from 'ng-zorro-antd/core/util';
   template: `
     <div class="ant-input-number-handler-wrap">
       <span
+        role="button"
+        aria-label="Increase Value"
         unselectable="unselectable"
         class="ant-input-number-handler ant-input-number-handler-up"
         (mousedown)="up($event)"
         (mouseup)="stop()"
         (mouseleave)="stop()"
         [class.ant-input-number-handler-up-disabled]="disabledUp"
+        [attr.aria-disabled]="nzDisabled || disabledUp ? true : null"
       >
         <i nz-icon nzType="up" class="ant-input-number-handler-up-inner"></i>
       </span>
       <span
+        role="button"
+        aria-label="Decrease Value"
         unselectable="unselectable"
         class="ant-input-number-handler ant-input-number-handler-down"
         (mousedown)="down($event)"
         (mouseup)="stop()"
         (mouseleave)="stop()"
         [class.ant-input-number-handler-down-disabled]="disabledDown"
+        [attr.aria-disabled]="nzDisabled || disabledDown ? true : null"
       >
         <i nz-icon nzType="down" class="ant-input-number-handler-down-inner"></i>
       </span>
@@ -56,6 +62,7 @@ import { InputBoolean, isNotNil } from 'ng-zorro-antd/core/util';
     <div class="ant-input-number-input-wrap">
       <input
         #inputElement
+        role="spinbutton"
         autocomplete="off"
         class="ant-input-number-input"
         [attr.id]="nzId"
@@ -66,6 +73,9 @@ import { InputBoolean, isNotNil } from 'ng-zorro-antd/core/util';
         [placeholder]="nzPlaceHolder"
         [attr.step]="nzStep"
         [attr.inputmode]="nzInputMode"
+        [attr.aria-valuemin]="nzMin"
+        [attr.aria-valuemax]="nzMax"
+        [attr.aria-valuenow]="valuenow"
         (keydown)="onKeyDown($event)"
         (keyup)="stop()"
         [ngModel]="displayValue"
@@ -318,6 +328,10 @@ export class NzInputNumberComponent implements ControlValueAccessor, AfterViewIn
     }
   }
 
+  public get valuenow(): number | null {
+    return this.value || this.value === 0 ? this.value : null;
+  }
+
   updateDisplayValue(value: number): void {
     const displayValue = isNotNil(this.nzFormatter(value)) ? this.nzFormatter(value) : '';
     this.displayValue = displayValue;
diff --git a/components/input-number/input-number.spec.ts b/components/input-number/input-number.spec.ts
index 23216923687..4ae4c3df559 100644
--- a/components/input-number/input-number.spec.ts
+++ b/components/input-number/input-number.spec.ts
@@ -395,6 +395,69 @@ describe('input number', () => {
       fixture.detectChanges();
       expect(inputNumber.nativeElement.classList).not.toContain('ant-input-number-focused');
     });
+    it('should aria roles and labels work', () => {
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('role')).toBe('spinbutton');
+      expect(upHandler.getAttribute('role')).toBe('button');
+      expect(downHandler.getAttribute('role')).toBe('button');
+      expect(upHandler.getAttribute('aria-label')).toBe('Increase Value');
+      expect(downHandler.getAttribute('aria-label')).toBe('Decrease Value');
+    });
+    it('should aria value attributes work', () => {
+      testComponent.min = 0;
+      testComponent.max = 10;
+
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('aria-valuemin')).toBe('0');
+      expect(inputElement.getAttribute('aria-valuemax')).toBe('10');
+      expect(inputElement.getAttribute('aria-valuenow')).toBe(null);
+
+      testComponent.nzInputNumberComponent.onModelChange('5');
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('aria-valuenow')).toBe('5');
+
+      dispatchFakeEvent(upHandler, 'mousedown');
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('aria-valuenow')).toBe('6');
+
+      dispatchFakeEvent(downHandler, 'mousedown');
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('aria-valuenow')).toBe('5');
+
+      testComponent.min = 3;
+      testComponent.max = 15;
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('aria-valuemin')).toBe('3');
+      expect(inputElement.getAttribute('aria-valuemax')).toBe('15');
+      expect(inputElement.getAttribute('aria-valuenow')).toBe('5');
+
+      testComponent.nzInputNumberComponent.onModelChange('');
+      fixture.detectChanges();
+      expect(inputElement.getAttribute('aria-valuenow')).toBe(null);
+    });
+    it('should aria disabled work', () => {
+      fixture.detectChanges();
+      expect(upHandler.getAttribute('aria-disabled')).not.toBe('true');
+      expect(downHandler.getAttribute('aria-disabled')).not.toBe('true');
+
+      testComponent.max = 1;
+      testComponent.nzInputNumberComponent.onModelChange('1');
+      fixture.detectChanges();
+      expect(upHandler.getAttribute('aria-disabled')).toBe('true');
+      expect(downHandler.getAttribute('aria-disabled')).not.toBe('true');
+
+      testComponent.min = -1;
+      testComponent.nzInputNumberComponent.onModelChange('-1');
+      fixture.detectChanges();
+      expect(upHandler.getAttribute('aria-disabled')).not.toBe('true');
+      expect(downHandler.getAttribute('aria-disabled')).toBe('true');
+
+      testComponent.nzInputNumberComponent.onModelChange('0');
+      testComponent.disabled = true;
+      fixture.detectChanges();
+      expect(upHandler.getAttribute('aria-disabled')).toBe('true');
+      expect(downHandler.getAttribute('aria-disabled')).toBe('true');
+    });
   });
 
   describe('input number form', () => {
@@ -454,8 +517,7 @@ describe('input number', () => {
       [nzParser]="parser"
       [nzPrecision]="precision"
       [nzPrecisionMode]="precisionMode"
-    >
-    </nz-input-number>
+    ></nz-input-number>
   `
 })
 export class NzTestInputNumberBasicComponent {
diff --git a/components/menu/menu-item.directive.ts b/components/menu/menu-item.directive.ts
index 564cfb8c093..4c4362ee0a0 100644
--- a/components/menu/menu-item.directive.ts
+++ b/components/menu/menu-item.directive.ts
@@ -37,7 +37,9 @@ import { NzSubmenuService } from './submenu.service';
     '[class.ant-menu-item-selected]': `!isMenuInsideDropDown && nzSelected`,
     '[class.ant-menu-item-disabled]': `!isMenuInsideDropDown && nzDisabled`,
     '[style.paddingLeft.px]': 'nzPaddingLeft || inlinePaddingLeft',
-    '(click)': 'clickMenuItem($event)'
+    '(click)': 'clickMenuItem($event)',
+    '[attr.aria-disabled]': 'nzDisabled? true:null',
+    role: 'menuitem'
   }
 })
 export class NzMenuItemDirective implements OnInit, OnChanges, OnDestroy, AfterContentInit {
diff --git a/components/menu/menu.directive.ts b/components/menu/menu.directive.ts
index 5481bebe481..799501a05d2 100644
--- a/components/menu/menu.directive.ts
+++ b/components/menu/menu.directive.ts
@@ -30,6 +30,8 @@ import { NzIsMenuInsideDropDownToken, NzMenuServiceLocalToken } from './menu.tok
 import { NzMenuModeType, NzMenuThemeType } from './menu.types';
 import { NzSubMenuComponent } from './submenu.component';
 
+let menus = 0;
+
 export function MenuServiceFactory(serviceInsideDropDown: MenuService, serviceOutsideDropDown: MenuService): MenuService {
   return serviceInsideDropDown ? serviceInsideDropDown : serviceOutsideDropDown;
 }
@@ -74,7 +76,8 @@ export function MenuDropDownTokenFactory(isMenuInsideDropDownToken: boolean): bo
     '[class.ant-menu-vertical]': `!isMenuInsideDropDown && actualMode === 'vertical'`,
     '[class.ant-menu-horizontal]': `!isMenuInsideDropDown && actualMode === 'horizontal'`,
     '[class.ant-menu-inline]': `!isMenuInsideDropDown && actualMode === 'inline'`,
-    '[class.ant-menu-inline-collapsed]': `!isMenuInsideDropDown && nzInlineCollapsed`
+    '[class.ant-menu-inline-collapsed]': `!isMenuInsideDropDown && nzInlineCollapsed`,
+    role: 'menu'
   }
 })
 export class NzMenuDirective implements AfterContentInit, OnInit, OnChanges, OnDestroy {
@@ -116,7 +119,9 @@ export class NzMenuDirective implements AfterContentInit, OnInit, OnChanges, OnD
     private nzMenuService: MenuService,
     @Inject(NzIsMenuInsideDropDownToken) public isMenuInsideDropDown: boolean,
     private cdr: ChangeDetectorRef
-  ) {}
+  ) {
+    nzMenuService.setMenuId(++menus);
+  }
 
   ngOnInit(): void {
     combineLatest([this.inlineCollapsed$, this.mode$])
diff --git a/components/menu/menu.service.ts b/components/menu/menu.service.ts
index 2c63a7a5f51..2473fd58a20 100644
--- a/components/menu/menu.service.ts
+++ b/components/menu/menu.service.ts
@@ -18,6 +18,8 @@ export class MenuService {
   mode$ = new BehaviorSubject<NzMenuModeType>('vertical');
   inlineIndent$ = new BehaviorSubject<number>(24);
   isChildSubMenuOpen$ = new BehaviorSubject<boolean>(false);
+  subMenus: number = 0;
+  menuId: number = 0;
 
   onDescendantMenuItemClick(menu: NzSafeAny): void {
     this.descendantMenuItemClick$.next(menu);
@@ -38,4 +40,10 @@ export class MenuService {
   setInlineIndent(indent: number): void {
     this.inlineIndent$.next(indent);
   }
+  setMenuId(id: number): void {
+    this.menuId = id;
+  }
+  getNewSubmenuId(): number {
+    return ++this.subMenus;
+  }
 }
diff --git a/components/menu/menu.spec.ts b/components/menu/menu.spec.ts
index 0f83c80c773..ba821a61328 100644
--- a/components/menu/menu.spec.ts
+++ b/components/menu/menu.spec.ts
@@ -75,6 +75,26 @@ describe('menu', () => {
         fixture.detectChanges();
         expect(items[0].nativeElement.classList.contains('ant-menu-item-selected')).toBe(false);
       });
+      it('should roles correct', () => {
+        fixture.detectChanges();
+        expect(items.every(item => item.nativeElement.getAttribute('role') === 'menuitem')).toBe(true);
+        expect(submenu.nativeElement.getAttribute('role')).toBe('menuitem');
+        expect(submenu.nativeElement.firstElementChild.getAttribute('role')).toBe('button');
+        expect(menu.nativeElement.getAttribute('role')).toBe('menu');
+      });
+      it('should aria-disabled correct', () => {
+        fixture.detectChanges();
+        expect(items[1].nativeElement.getAttribute('aria-disabled')).toBe('true');
+      });
+      it('should submenu aria correct', () => {
+        fixture.detectChanges();
+
+        const title = submenu.nativeElement.querySelector('.ant-menu-submenu-title');
+        const id: string = title.getAttribute('aria-owns');
+        expect(id).toContain('sub1$Menu');
+        expect(title.getAttribute('aria-haspopup')).toBe('menu');
+        expect(title.getAttribute('aria-expanded')).toBe('false');
+      });
     });
     describe('inline', () => {
       let fixture: ComponentFixture<NzTestBasicMenuInlineComponent>;
@@ -116,6 +136,30 @@ describe('menu', () => {
         expect(ul.style.height).toBe('0px');
         expect(submenus[0].nativeElement.classList.contains('ant-menu-submenu-open')).toBe(false);
       }));
+      it('should roles correct', () => {
+        fixture.detectChanges();
+        expect(items.every(item => item.nativeElement.getAttribute('role') === 'menuitem')).toBe(true);
+        expect(submenus.every(submenu => submenu.nativeElement.getAttribute('role') === 'menuitem')).toBe(true);
+        expect(
+          submenus.every(submenu => submenu.nativeElement.querySelector('.ant-menu-submenu-title').getAttribute('role') === 'button')
+        ).toBe(true);
+        expect(submenus.every(submenu => submenu.nativeElement.querySelector('ul').getAttribute('role') === 'menu')).toBe(true);
+        expect(menu.nativeElement.getAttribute('role')).toBe('menu');
+      });
+      it('should submenu aria correct', () => {
+        fixture.detectChanges();
+
+        submenus.forEach(submenu => {
+          const ul = submenu.nativeElement.querySelector('ul');
+          const title = submenu.nativeElement.querySelector('.ant-menu-submenu-title');
+          const id: string = title.getAttribute('aria-owns');
+          expect(id).toContain(`sub`);
+          expect(id).toContain(`$Menu`);
+          expect(title.getAttribute('aria-haspopup')).toBe('menu');
+          expect(title.getAttribute('aria-expanded')).toBe('false');
+          expect(ul.getAttribute('id')).toBe(id);
+        });
+      });
     });
     describe('inline-collapsed', () => {
       let fixture: ComponentFixture<NzTestMenuInlineCollapsedComponent>;
@@ -402,6 +446,32 @@ describe('menu', () => {
         fixture.detectChanges();
         expect((overlayContainerElement.querySelector('.nested-submenu') as HTMLUListElement).classList).toContain('ant-menu-sub');
       });
+      it('should submenu roles correct', () => {
+        fixture.detectChanges();
+        const title = submenu.nativeElement.querySelector('.ant-menu-submenu-title');
+        expect(submenu.nativeElement.getAttribute('role')).toBe('menuitem');
+        expect(title?.getAttribute('role')).toBe('button');
+        testComponent.open = true;
+        fixture.detectChanges();
+        const ul = overlayContainerElement.querySelector('ul');
+        expect(ul?.getAttribute('role')).toBe('menu');
+      });
+      it('should submenu aria correct', () => {
+        fixture.detectChanges();
+        const title = submenu.nativeElement.querySelector('.ant-menu-submenu-title');
+
+        const id: string = title.getAttribute('aria-owns');
+        expect(id).toContain('sub1$Menu');
+        expect(title.getAttribute('aria-haspopup')).toBe('menu');
+        expect(title.getAttribute('aria-expanded')).toBe('false');
+
+        testComponent.open = true;
+        fixture.detectChanges();
+        const ul = overlayContainerElement.querySelector('ul');
+
+        expect(title?.getAttribute('aria-expanded')).toBe('true');
+        expect(ul?.getAttribute('id')).toBe(id);
+      });
     });
     describe('inline submenu', () => {
       let fixture: ComponentFixture<NzTestMenuInlineComponent>;
@@ -446,6 +516,36 @@ describe('menu', () => {
         expect(ul.style.height).toBe('0px');
         expect(submenu.nativeElement.classList.contains('ant-menu-submenu-open')).toBe(false);
       }));
+      it('should submenu roles correct', () => {
+        fixture.detectChanges();
+        const ul = submenu.nativeElement.querySelector('ul');
+        const title = submenu.nativeElement.querySelector('.ant-menu-submenu-title');
+        expect(submenu.nativeElement.getAttribute('role')).toBe('menuitem');
+        expect(title.getAttribute('role')).toBe('button');
+        expect(ul.getAttribute('role')).toBe('menu');
+      });
+      it('should aria-disabled work', () => {
+        testComponent.disabled = true;
+        fixture.detectChanges();
+        expect(submenu.nativeElement.getAttribute('aria-disabled')).toBe('true');
+      });
+      it('should submenu aria correct', fakeAsync(() => {
+        fixture.detectChanges();
+
+        const ul = submenu.nativeElement.querySelector('ul');
+        const title = submenu.nativeElement.querySelector('.ant-menu-submenu-title');
+        const id: string = title.getAttribute('aria-owns');
+        expect(id).toContain('sub1$Menu');
+        expect(title.getAttribute('aria-haspopup')).toBe('menu');
+        expect(title.getAttribute('aria-expanded')).toBe('false');
+
+        title.click();
+        fixture.detectChanges();
+        tick(500);
+
+        expect(title.getAttribute('aria-expanded')).toBe('true');
+        expect(ul.getAttribute('id')).toBe(id);
+      }));
     });
     describe('ng-for', () => {
       it('should ng for works fine', () => {
@@ -475,7 +575,10 @@ describe('menu', () => {
   template: `
     <ul nz-menu [nzMode]="'horizontal'">
       <li nz-submenu nzMenuClassName="submenu" [nzOpen]="open" [style.width.px]="width">
-        <span title><i nz-icon nzType="setting"></i> Navigation Three - Submenu</span>
+        <span title>
+          <i nz-icon nzType="setting"></i>
+          Navigation Three - Submenu
+        </span>
         <ul>
           <li nz-menu-group>
             <span title>Item 1</span>
@@ -524,7 +627,10 @@ export class NzTestMenuHorizontalComponent {
   template: `
     <ul nz-menu [nzMode]="'inline'" [nzInlineCollapsed]="collapse">
       <li nz-submenu [nzMenuClassName]="submenuClassName" [nzDisabled]="disabled">
-        <span title><i nz-icon nzType="mail"></i> Navigation One</span>
+        <span title>
+          <i nz-icon nzType="mail"></i>
+          Navigation One
+        </span>
         <ul>
           <li nz-menu-item style="padding-left:0px;">Option 1</li>
           <li nz-menu-item>Option 2</li>
@@ -545,7 +651,10 @@ export class NzTestMenuInlineComponent {
   template: `
     <ul nz-menu [nzMode]="'inline'" style="width: 240px;">
       <li *ngFor="let l1 of menus" nz-submenu>
-        <span title><i nz-icon nzType="appstore"></i> {{ l1.text }}</span>
+        <span title>
+          <i nz-icon nzType="appstore"></i>
+          {{ l1.text }}
+        </span>
         <ul>
           <li *ngFor="let l2 of l1.children" nz-submenu>
             <span title>{{ l2.text }}</span>
diff --git a/components/menu/submenu-inline-child.component.ts b/components/menu/submenu-inline-child.component.ts
index 9e1e42741e2..1c791f009c9 100644
--- a/components/menu/submenu-inline-child.component.ts
+++ b/components/menu/submenu-inline-child.component.ts
@@ -4,6 +4,7 @@
  */
 
 import {
+  AfterViewInit,
   ChangeDetectionStrategy,
   Component,
   ElementRef,
@@ -25,7 +26,9 @@ import { NzMenuModeType } from './menu.types';
   exportAs: 'nzSubmenuInlineChild',
   encapsulation: ViewEncapsulation.None,
   changeDetection: ChangeDetectionStrategy.OnPush,
-  template: ` <ng-template [ngTemplateOutlet]="templateOutlet"></ng-template> `,
+  template: `
+    <ng-template [ngTemplateOutlet]="templateOutlet"></ng-template>
+  `,
   host: {
     '[class.ant-menu]': 'true',
     '[class.ant-menu-inline]': 'true',
@@ -33,11 +36,12 @@ import { NzMenuModeType } from './menu.types';
     '[@collapseMotion]': 'expandState'
   }
 })
-export class NzSubmenuInlineChildComponent implements OnInit, OnChanges {
+export class NzSubmenuInlineChildComponent implements AfterViewInit, OnInit, OnChanges {
   @Input() templateOutlet: TemplateRef<NzSafeAny> | null = null;
   @Input() menuClass: string = '';
   @Input() mode: NzMenuModeType = 'vertical';
   @Input() nzOpen = false;
+  @Input() menuId: string = '';
   listOfCacheClassName: string[] = [];
   expandState = 'collapsed';
   calcMotionState(): void {
@@ -74,4 +78,11 @@ export class NzSubmenuInlineChildComponent implements OnInit, OnChanges {
       }
     }
   }
+  ngAfterViewInit(): void {
+    const menuElement = this.elementRef.nativeElement.querySelector('ul');
+    menuElement?.setAttribute('role', 'menu');
+    if (this.menuId !== '') {
+      menuElement?.setAttribute('id', this.menuId);
+    }
+  }
 }
diff --git a/components/menu/submenu-non-inline-child.component.ts b/components/menu/submenu-non-inline-child.component.ts
index 30152d3f485..a1fb9d04e08 100644
--- a/components/menu/submenu-non-inline-child.component.ts
+++ b/components/menu/submenu-non-inline-child.component.ts
@@ -4,8 +4,10 @@
  */
 
 import {
+  AfterViewInit,
   ChangeDetectionStrategy,
   Component,
+  ElementRef,
   EventEmitter,
   Input,
   OnChanges,
@@ -52,7 +54,7 @@ import { NzMenuModeType, NzMenuThemeType } from './menu.types';
     '(mouseleave)': 'setMouseState(false)'
   }
 })
-export class NzSubmenuNoneInlineChildComponent implements OnInit, OnChanges {
+export class NzSubmenuNoneInlineChildComponent implements AfterViewInit, OnInit, OnChanges {
   @Input() menuClass: string = '';
   @Input() theme: NzMenuThemeType = 'light';
   @Input() templateOutlet: TemplateRef<NzSafeAny> | null = null;
@@ -61,7 +63,11 @@ export class NzSubmenuNoneInlineChildComponent implements OnInit, OnChanges {
   @Input() position = 'right';
   @Input() nzDisabled = false;
   @Input() nzOpen = false;
+  @Input() menuId: string = '';
   @Output() readonly subMenuMouseState = new EventEmitter<boolean>();
+
+  constructor(private elementRef: ElementRef) {}
+
   setMouseState(state: boolean): void {
     if (!this.nzDisabled) {
       this.subMenuMouseState.next(state);
@@ -88,4 +94,12 @@ export class NzSubmenuNoneInlineChildComponent implements OnInit, OnChanges {
       this.calcMotionState();
     }
   }
+
+  ngAfterViewInit(): void {
+    const menuElement = this.elementRef.nativeElement.querySelector('ul');
+    menuElement?.setAttribute('role', 'menu');
+    if (this.menuId !== '') {
+      menuElement?.setAttribute('id', this.menuId);
+    }
+  }
 }
diff --git a/components/menu/submenu.component.ts b/components/menu/submenu.component.ts
index 4c7a064c08c..90162d02666 100644
--- a/components/menu/submenu.component.ts
+++ b/components/menu/submenu.component.ts
@@ -69,6 +69,10 @@ const listOfHorizontalPositions = [POSITION_MAP.bottomLeft];
       [paddingLeft]="nzPaddingLeft || inlinePaddingLeft"
       (subMenuMouseState)="setMouseEnterState($event)"
       (toggleSubMenu)="toggleSubMenu()"
+      role="button"
+      aria-haspopup="menu"
+      [attr.aria-expanded]="nzOpen"
+      [attr.aria-owns]="idString"
     >
       <ng-content select="[title]" *ngIf="!nzTitle"></ng-content>
     </div>
@@ -81,6 +85,7 @@ const listOfHorizontalPositions = [POSITION_MAP.bottomLeft];
       [nzNoAnimation]="noAnimation?.nzNoAnimation"
       [menuClass]="nzMenuClassName"
       [templateOutlet]="subMenuTemplate"
+      [menuId]="idString"
     ></div>
     <ng-template #nonInlineTemplate>
       <ng-template
@@ -102,6 +107,7 @@ const listOfHorizontalPositions = [POSITION_MAP.bottomLeft];
           [isMenuInsideDropDown]="isMenuInsideDropDown"
           [templateOutlet]="subMenuTemplate"
           [menuClass]="nzMenuClassName"
+          [menuId]="idString"
           [@.disabled]="noAnimation?.nzNoAnimation"
           [nzNoAnimation]="noAnimation?.nzNoAnimation"
           (subMenuMouseState)="setMouseEnterState($event)"
@@ -129,7 +135,9 @@ const listOfHorizontalPositions = [POSITION_MAP.bottomLeft];
     '[class.ant-menu-submenu-vertical]': `!isMenuInsideDropDown && mode === 'vertical'`,
     '[class.ant-menu-submenu-horizontal]': `!isMenuInsideDropDown && mode === 'horizontal'`,
     '[class.ant-menu-submenu-inline]': `!isMenuInsideDropDown && mode === 'inline'`,
-    '[class.ant-menu-submenu-active]': `!isMenuInsideDropDown && isActive`
+    '[class.ant-menu-submenu-active]': `!isMenuInsideDropDown && isActive`,
+    '[attr.aria-disabled]': 'nzDisabled? "true":null',
+    role: 'menuitem'
   }
 })
 export class NzSubMenuComponent implements OnInit, OnDestroy, AfterContentInit, OnChanges {
@@ -158,6 +166,7 @@ export class NzSubMenuComponent implements OnInit, OnDestroy, AfterContentInit,
   overlayPositions = listOfVerticalPositions;
   isSelected = false;
   isActive = false;
+  idString: string = '';
 
   /** set the submenu host open status directly **/
   setOpenStateWithoutDebounce(open: boolean): void {
@@ -199,7 +208,11 @@ export class NzSubMenuComponent implements OnInit, OnDestroy, AfterContentInit,
     private platform: Platform,
     @Inject(NzIsMenuInsideDropDownToken) public isMenuInsideDropDown: boolean,
     @Host() @Optional() public noAnimation?: NzNoAnimationDirective
-  ) {}
+  ) {
+    const menuId = this.nzMenuService.menuId;
+    const submenuId = this.nzSubmenuService.id;
+    this.idString = `sub${submenuId}$Menu${menuId}`;
+  }
 
   ngOnInit(): void {
     /** submenu theme update **/
diff --git a/components/menu/submenu.service.ts b/components/menu/submenu.service.ts
index 863319bbcec..28d837b4124 100644
--- a/components/menu/submenu.service.ts
+++ b/components/menu/submenu.service.ts
@@ -26,6 +26,7 @@ export class NzSubmenuService {
     })
   );
   level = 1;
+  id: number = 0;
   isCurrentSubMenuOpen$ = new BehaviorSubject<boolean>(false);
   private isChildSubMenuOpen$ = new BehaviorSubject<boolean>(false);
   /** submenu title & overlay mouse enter status **/
@@ -53,6 +54,7 @@ export class NzSubmenuService {
     if (this.nzHostSubmenuService) {
       this.level = this.nzHostSubmenuService.level + 1;
     }
+    this.id = this.nzMenuService.getNewSubmenuId();
     /** close if menu item clicked **/
     const isClosedByMenuItemClick = this.childMenuItemClick$.pipe(
       flatMap(() => this.mode$),
diff --git a/components/switch/switch.component.ts b/components/switch/switch.component.ts
index 8bea55d076b..53ff8a88b76 100644
--- a/components/switch/switch.component.ts
+++ b/components/switch/switch.component.ts
@@ -44,6 +44,7 @@ const NZ_CONFIG_COMPONENT_NAME = 'switch';
       nz-wave
       type="button"
       class="ant-switch"
+      role="switch"
       #switchElement
       [disabled]="nzDisabled"
       [class.ant-switch-checked]="isChecked"
@@ -51,6 +52,7 @@ const NZ_CONFIG_COMPONENT_NAME = 'switch';
       [class.ant-switch-disabled]="nzDisabled"
       [class.ant-switch-small]="nzSize === 'small'"
       [nzWaveExtraNode]="true"
+      [attr.aria-checked]="isChecked"
       (keydown)="onKeyDown($event)"
     >
       <span class="ant-switch-handle">
@@ -76,7 +78,8 @@ export class NzSwitchComponent implements ControlValueAccessor, AfterViewInit, O
   static ngAcceptInputType_nzDisabled: BooleanInput;
   static ngAcceptInputType_nzControl: BooleanInput;
 
-  isChecked = false;
+  isChecked: boolean = false;
+  temp: boolean = false;
   onChange: OnChangeType = () => {};
   onTouched: OnTouchedType = () => {};
   @ViewChild('switchElement', { static: true }) private switchElement?: ElementRef;
@@ -140,7 +143,7 @@ export class NzSwitchComponent implements ControlValueAccessor, AfterViewInit, O
   }
 
   writeValue(value: boolean): void {
-    this.isChecked = value;
+    this.isChecked = !!value;
     this.cdr.markForCheck();
   }
 
diff --git a/components/switch/switch.spec.ts b/components/switch/switch.spec.ts
index cdde96824a5..a540add4821 100644
--- a/components/switch/switch.spec.ts
+++ b/components/switch/switch.spec.ts
@@ -162,6 +162,27 @@ describe('switch', () => {
       fixture.detectChanges();
       expect(switchElement.nativeElement.firstElementChild === document.activeElement).toBe(false);
     });
+    it('should aria roles correct', () => {
+      expect(switchElement.nativeElement.firstElementChild!.getAttribute('role')).toBe('switch');
+    });
+    it('should aria states work', fakeAsync(() => {
+      fixture.detectChanges();
+      flush();
+      fixture.detectChanges();
+      expect(switchElement.nativeElement.firstElementChild!.getAttribute('aria-checked')).toBe('false');
+
+      switchElement.nativeElement.click();
+      fixture.detectChanges();
+      flush();
+      fixture.detectChanges();
+      expect(switchElement.nativeElement.firstElementChild!.getAttribute('aria-checked')).toBe('true');
+
+      switchElement.nativeElement.click();
+      fixture.detectChanges();
+      flush();
+      fixture.detectChanges();
+      expect(switchElement.nativeElement.firstElementChild!.getAttribute('aria-checked')).toBe('false');
+    }));
   });
   describe('template switch', () => {
     let fixture: ComponentFixture<NzTestSwitchTemplateComponent>;
@@ -236,8 +257,7 @@ describe('switch', () => {
       [nzControl]="control"
       [nzCheckedChildren]="checkedChildren"
       [nzUnCheckedChildren]="unCheckedChildren"
-    >
-    </nz-switch>
+    ></nz-switch>
   `
 })
 export class NzTestSwitchBasicComponent {
@@ -258,7 +278,7 @@ export class NzTestSwitchBasicComponent {
   template: `
     <ng-template #checkedChildrenTemplate><i nz-icon nzType="check"></i></ng-template>
     <ng-template #unCheckedChildrenTemplate><i nz-icon nzType="close"></i></ng-template>
-    <nz-switch [nzCheckedChildren]="checkedChildrenTemplate" [nzUnCheckedChildren]="unCheckedChildrenTemplate"> </nz-switch>
+    <nz-switch [nzCheckedChildren]="checkedChildrenTemplate" [nzUnCheckedChildren]="unCheckedChildrenTemplate"></nz-switch>
   `
 })
 export class NzTestSwitchTemplateComponent {}