Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize .NET Core implementation (NLog 5) #1559

Closed
3 tasks done
304NotModified opened this issue Jul 25, 2016 · 6 comments
Closed
3 tasks done

Finalize .NET Core implementation (NLog 5) #1559

304NotModified opened this issue Jul 25, 2016 · 6 comments
Labels
Milestone

Comments

@304NotModified
Copy link
Member

304NotModified commented Jul 25, 2016

See open tasks for .NET Core

Most important stuff to be done:

  • Fix getCurrentClassLogger (stacktrace ctor issue)
  • Fix ${basedir}
  • Fix running tests on AppVeyor

as continuation of #641

@304NotModified
Copy link
Member Author

@phenixdotnet maybe some time to help finishing this? Got the tests almost running on AppVeyor (locally 95% works)

@phenixdotnet
Copy link

@304NotModified I can try to get some time to help you with this but I can't promise anything

Anyway, thanks you to have pushed this you're doing an amazing work !

@304NotModified 304NotModified changed the title Finish .NET Core implementation Finalize .NET Core implementation Jul 26, 2016
@304NotModified 304NotModified modified the milestones: 4.4, 5.0 Aug 5, 2016
@snakefoot
Copy link
Contributor

snakefoot commented Oct 15, 2017

Guess this is fixed with NLog 4.5 ? (Supports NetStandard2.0 and NetStandard1.5 with #2341)

But maybe this issue is about finalizing the coreclr-branch?

@304NotModified
Copy link
Member Author

This was indeed for the coreCLR branch.

@304NotModified 304NotModified changed the title Finalize .NET Core implementation Finalize .NET Core implementation (NLog 5) Oct 15, 2017
@snakefoot
Copy link
Contributor

snakefoot commented Oct 15, 2017

These could be considered fixed on NLog 5-branch

  • Fix getCurrentClassLogger (stacktrace ctor issue)
  • Fix ${basedir}
  • Fix running tests on AppVeyor

The autoloading packages is very hard, because of the new nuget-style, so almost unfixable.

@304NotModified
Copy link
Member Author

The autoloading packages is very hard, because of the new nuget-style, so almost unfixable.

Indeed, and this is #1091, so I will close this one. thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants