From 69c1549fa80a04a21abd237e95d578cf9a22ce9c Mon Sep 17 00:00:00 2001
From: Jiarui Dong <Jiarui.Dong@noaa.gov>
Date: Sun, 3 Dec 2023 09:25:45 -0500
Subject: [PATCH] Manage the YAML files by using explicit filter ordering.

---
 parm/land/obs/config/adpsfc_snow.yaml | 37 +++++++++++++----------
 parm/land/obs/config/snocvr_snow.yaml | 43 ++++++++++++++-------------
 parm/land/prep/prep_ims.yaml          |  2 +-
 3 files changed, 45 insertions(+), 37 deletions(-)

diff --git a/parm/land/obs/config/adpsfc_snow.yaml b/parm/land/obs/config/adpsfc_snow.yaml
index a7c08eb74..d1403bad5 100644
--- a/parm/land/obs/config/adpsfc_snow.yaml
+++ b/parm/land/obs/config/adpsfc_snow.yaml
@@ -26,7 +26,22 @@ obs localizations:
     max nobs: 50
   - localization method: Vertical Brasnett
     vertical lengthscale: 700
-obs filters:
+obs pre filters:
+  - filter: Perform Action
+    filter variables:
+    - name: totalSnowDepth
+    action:
+      name: assign error
+      error parameter: 40.0
+  - filter: Variable Assignment
+    assignments:
+    - name: GrossErrorProbability/totalSnowDepth
+      type: float
+      value: 0.02
+    - name: BkgError/totalSnowDepth_background_error
+      type: float
+      value: 30.0
+obs prior filters:
   - filter: Bounds Check
     filter variables:
     - name: totalSnowDepth
@@ -57,12 +72,18 @@ obs filters:
         name: MetaData/stationIdentification
       is_in: [71120,71397,71621,71727,71816]
       size where true: 5
+obs post filters:
   - filter: Background Check # gross error check
     filter variables:
     - name: totalSnowDepth
     threshold: 6.25
     action:
       name: reject
+  - filter: Temporal Thinning
+    min_spacing: '{{ LAND_WINDOW_LENGTH }}'
+    seed_time: '{{ current_cycle | to_isotime }}'
+    category_variable:
+      name: MetaData/stationIdentification
   - filter: Met Office Buddy Check
     filter variables:
     - name: totalSnowDepth
@@ -86,18 +107,4 @@ obs filters:
       damping_factor_1: 1.0
       damping_factor_2: 1.0
       background_error_group: BkgError
-  - filter: Perform Action
-    filter variables:
-    - name: totalSnowDepth
-    action:
-      name: assign error
-      error parameter: 40.0
-  - filter: Variable Assignment
-    assignments:
-    - name: GrossErrorProbability/totalSnowDepth
-      type: float
-      value: 0.02
-    - name: BkgError/totalSnowDepth_background_error
-      type: float
-      value: 30.0
 
diff --git a/parm/land/obs/config/snocvr_snow.yaml b/parm/land/obs/config/snocvr_snow.yaml
index 3dade008b..9d25f9302 100644
--- a/parm/land/obs/config/snocvr_snow.yaml
+++ b/parm/land/obs/config/snocvr_snow.yaml
@@ -26,7 +26,22 @@ obs localizations:
     max nobs: 50
   - localization method: Vertical Brasnett
     vertical lengthscale: 700
-obs filters:
+obs pre filters:
+  - filter: Perform Action
+    filter variables:
+    - name: totalSnowDepth
+    action:
+      name: assign error
+      error parameter: 40.0
+  - filter: Variable Assignment
+    assignments:
+    - name: GrossErrorProbability/totalSnowDepth
+      type: float
+      value: 0.02
+    - name: BkgError/totalSnowDepth_background_error
+      type: float
+      value: 30.0
+obs prior filters:
   - filter: Bounds Check
     filter variables:
     - name: totalSnowDepth
@@ -51,17 +66,18 @@ obs filters:
         name: GeoVaLs/vtype
       minvalue: 14.5
       maxvalue: 15.5
-  - filter: Temporal Thinning
-    min_spacing: '{{ LAND_WINDOW_LENGTH }}'
-    seed_time: '{{ current_cycle | to_isotime }}'
-    category_variable:
-      name: MetaData/stationIdentification
+obs post filters:
   - filter: Background Check # gross error check
     filter variables:
     - name: totalSnowDepth
     threshold: 6.25
     action:
       name: reject
+  - filter: Temporal Thinning
+    min_spacing: '{{ LAND_WINDOW_LENGTH }}'
+    seed_time: '{{ current_cycle | to_isotime }}'
+    category_variable:
+      name: MetaData/stationIdentification
   - filter: Met Office Buddy Check
     filter variables:
     - name: totalSnowDepth
@@ -85,18 +101,3 @@ obs filters:
       damping_factor_1: 1.0
       damping_factor_2: 1.0
       background_error_group: BkgError
-  - filter: Perform Action
-    filter variables:
-    - name: totalSnowDepth
-    action:
-      name: assign error
-      error parameter: 40.0
-  - filter: Variable Assignment
-    assignments:
-    - name: GrossErrorProbability/totalSnowDepth
-      type: float
-      value: 0.02
-    - name: BkgError/totalSnowDepth_background_error
-      type: float
-      value: 30.0
-
diff --git a/parm/land/prep/prep_ims.yaml b/parm/land/prep/prep_ims.yaml
index 23b0feb38..d37d58a44 100644
--- a/parm/land/prep/prep_ims.yaml
+++ b/parm/land/prep/prep_ims.yaml
@@ -6,5 +6,5 @@ calcfims:
     - [$(COM_OBS)/$(OPREFIX)IMS4km_to_FV3_mapping.$(CASE)_oro_data.nc, $(DATA)/obs/IMS4km_to_FV3_mapping.$(CASE)_oro_data.nc]
 ims2ioda:
   copy:
-    - [$(DATA)/ims_snow_{{ current_cycle | to_YMDH }}.nc4, $(COM_OBS)/$(OPREFIX)ims_snow.nc4]
+    - [$(DATA)/ims_snow_{{ current_cycle | to_YMDH }}.nc4, $(DATA)/obs/$(OPREFIX)ims_snow.nc4]