From 1661c15183a388742d67baf70621c93773f5830f Mon Sep 17 00:00:00 2001
From: jderber-NOAA <75998838+jderber-NOAA@users.noreply.github.com>
Date: Fri, 14 Apr 2023 18:22:00 -0400
Subject: [PATCH] Fix write_incr (#559)

---
 src/gsi/write_incr.f90 | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/gsi/write_incr.f90 b/src/gsi/write_incr.f90
index e312199998..b22be8de30 100644
--- a/src/gsi/write_incr.f90
+++ b/src/gsi/write_incr.f90
@@ -76,6 +76,7 @@ subroutine write_fv3_inc_ (grd,sp_a,filename,mype_out,gfs_bundle,ibin)
     use general_sub2grid_mod, only: sub2grid_info
 
     use gsi_bundlemod, only: gsi_bundle, gsi_bundlegetpointer
+    use gsi_bundlemod, only: assignment(=)
     use control_vectors, only: control_vector
 
     use constants, only: one, rad2deg, r1000
@@ -158,7 +159,6 @@ subroutine write_fv3_inc_ (grd,sp_a,filename,mype_out,gfs_bundle,ibin)
 !   set up state space based off of xhatsave
 !   Convert from control space directly to physical
 !   space for comparison with obs.
-    call allocate_preds(sbiasinc)
     do iii=1,nobs_bins
        call allocate_state(svalinc(iii))
     end do
@@ -168,7 +168,10 @@ subroutine write_fv3_inc_ (grd,sp_a,filename,mype_out,gfs_bundle,ibin)
     do iii=1,ntlevs_ens
        call allocate_state(evalinc(iii))
     end do
+
+    call allocate_preds(sbiasinc)
     call control2state(xhatsave,mvalinc,sbiasinc)
+    call deallocate_preds(sbiasinc)
 
     if (l4dvar) then
        if (l_hyb_ens) then
@@ -193,6 +196,12 @@ subroutine write_fv3_inc_ (grd,sp_a,filename,mype_out,gfs_bundle,ibin)
           end do
        end if
     end if
+    do iii=1,ntlevs_ens
+       call deallocate_state(evalinc(iii))
+    end do
+    do iii=1,nsubwin
+       call deallocate_state(mvalinc(iii))
+    end do
 
     ! Check hydrometeors in control variables 
     iql = getindex(svars3d,'ql')
@@ -527,6 +536,10 @@ subroutine write_fv3_inc_ (grd,sp_a,filename,mype_out,gfs_bundle,ibin)
     endif
 !    ! cleanup and exit
     call nccheck_incr(nf90_close(ncid_out))
+    deallocate(out3d)
+    do iii=1,nobs_bins
+       call deallocate_state(svalinc(iii))
+    end do
     if ( mype == mype_out ) then
        write(6,*) "FV3 netCDF increment written, file= "//trim(filename)//".nc"
     end if