From eaa65eaaac36a136e3107782837eb3827d97f632 Mon Sep 17 00:00:00 2001 From: Alex Richert Date: Fri, 22 Nov 2024 15:04:01 -0800 Subject: [PATCH] Require CMake>=3.18 (#260) * CMakeLists.txt: minimum cmake 3.18 (LAPACK::LAPACK) * package.py: minimum cmake=3.18 * developer.yml: gcovr --gcov-ignore-parse-errors * developer.yml: use gcovr==7.2; revert --gcov-ignore-parse-errors --- .github/workflows/developer.yml | 2 +- CMakeLists.txt | 4 ++-- spack/package.py | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/developer.yml b/.github/workflows/developer.yml index 852d4bf1..ecdd1bce 100644 --- a/.github/workflows/developer.yml +++ b/.github/workflows/developer.yml @@ -26,7 +26,7 @@ jobs: run: | sudo apt-get update sudo apt-get install doxygen libopenblas-dev - python3 -m pip install gcovr + python3 -m pip install gcovr==7.2 - name: checkout uses: actions/checkout@v4 diff --git a/CMakeLists.txt b/CMakeLists.txt index 52d19cdc..b6ac912a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,7 +1,7 @@ # This is the main CMake file for NCEPLIBS-ip. # -# Mark Potts, Kyle Gerheiser, Eric Engle, Ed Hartnett -cmake_minimum_required(VERSION 3.15) +# Mark Potts, Kyle Gerheiser, Eric Engle, Ed Hartnett, Alex Richert +cmake_minimum_required(VERSION 3.18) # Get the version from the VERSION file. file(STRINGS "VERSION" pVersion) diff --git a/spack/package.py b/spack/package.py index 86254c42..1c864fd5 100644 --- a/spack/package.py +++ b/spack/package.py @@ -67,6 +67,7 @@ class Ip(CMakePackage): depends_on("sp precision=d", when="@4.1:4 precision=d") depends_on("sp precision=8", when="@4.1:4 precision=8") depends_on("lapack", when="@5.1:") + depends_on("cmake@3.18:", when="@5.1:") def cmake_args(self): args = [