Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent time in air density input #811

Closed
ukmo-juan-castillo opened this issue Sep 29, 2022 · 0 comments · Fixed by #812
Closed

Inconsistent time in air density input #811

ukmo-juan-castillo opened this issue Sep 29, 2022 · 0 comments · Fixed by #812
Labels
bug Something isn't working

Comments

@ukmo-juan-castillo
Copy link
Collaborator

Describe the bug
If driving data is read from file, the consistency of the times in the file is checked in the W3WAVE subroutine. This is done to make sure that the driving data contains valid data for the time of the run. In the case of air density, the times read from the momentum driving data file are used, which is wrong and can cause false errors. To fix the problem, the variables TR0 and TRN have to be used instead of TU0 and TUN when testing the air density file.

To Reproduce
Any run using air density but not momentum driving data.

Expected behavior
The previously described configuration will fail will with the error:

' *** WAVEWATCH III ERROR IN W3WAVE :'
' NEW AIR DENSITY BEFORE OLD AIR DENSITY '
irrespective of the validity of the driving data.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
The proposed fix has been successfully tested at the Met Office using the AMM15-SMC configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant