Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting of bl_mynn_tkebudget in GFS_typedefs.F90 (affects diagnostics only) #251

Open
climbfuji opened this issue Mar 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@climbfuji
Copy link
Collaborator

@egrell found a bug related to setting the bl_mynn_tkebudget control variable in GFS_typedefs.F90. In particular, the bl_mynn_tkebudget variable is not read in via namelist nor set. This should only affect diagnostic output of the MYNN PBL scheme.

To fix, simply add a couple of lines:

Add the bl_mynn_tkebudget around line 3446 (

bl_mynn_cloudpdf, bl_mynn_edmf, bl_mynn_edmf_mom, &
).
Add Model%bl_mynn_tkebudget = bl_mynn_tkebudget around line 4038 (
Model%bl_mynn_cloudpdf = bl_mynn_cloudpdf
).

This bug affects both the SCM and FV3 versions of the GFS_typedefs.F90 file. Ideally, it should be fixed in both repositories simultaneously. The corresponding issue for the CCPP SCM is NCAR/ccpp-scm#238, and the text in this fv3atm issue here was mostly stolen from @grantfirl, who created the SCM issue.

While fixing this issue, other MYNN PBL/SFC related variables should be checked, too.

@climbfuji climbfuji added the bug Something isn't working label Mar 3, 2021
@climbfuji
Copy link
Collaborator Author

@joeolson42 FYI

@joeolson42
Copy link
Contributor

This TKE budget option has been kept "hidden" because the diagnostic output is somewhat broken in the current code. I have some fixes coming. I'll make sure the namelist option are straightened out as I finish that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants