Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prod_util hack from UFSDA module load script #1350

Closed
CoryMartin-NOAA opened this issue Feb 28, 2023 · 2 comments
Closed

Remove prod_util hack from UFSDA module load script #1350

CoryMartin-NOAA opened this issue Feb 28, 2023 · 2 comments
Assignees
@CoryMartin-NOAA

Comments

@CoryMartin-NOAA
Copy link
Contributor

Description
Discussed in #1349 and offline with @aerorahul , there really is no need for prod_util things here besides a UTILROOT in config.base. This should be cleaned up/fixed properly.

Requirements
Make UTILROOT not cause failures in set -e mode.
Do not do an ugly hack in ush/load_ufsda_modules.sh for prod_util

Acceptance Criteria (Definition of Done)
Tested and cleaned up

Dependencies
None known
@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Feb 28, 2023
@aerorahul
Copy link
Contributor

Does spack-stack 1.6.0 resolve this issue where UTILROOT is defined differently/correctly?

@WalterKolczynski-NOAA
Copy link
Contributor

This was handled long ago in #2245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CoryMartin-NOAA @aerorahul @WalterKolczynski-NOAA