Add domain level to wave gridded COM path #3137
Conversation
jobs/JGLOBAL_WAVE_POST_SBS
Outdated
| @@ -19,6 +19,14 @@ for out_dir in "${COMOUT_WAVE_PREP}" "${COMOUT_WAVE_GRID}"; do | |||
| if [[ ! -d "${out_dir}" ]]; then mkdir -p "${out_dir}"; fi | |||
| done | |||
|
|
|||
| for grid in "0p25" "0p50" "1p00"; do | |||
There was a problem hiding this comment.
@AntonMFernando-NOAA I know this is a work in progress - but I was looking at this and I'm curious how these grids here were chosen? Especially as the description of the PR seems to imply that we'll use directory names such as global.0p16 or arctic.9km?
There was a problem hiding this comment.
@AntonMFernando-NOAA I know this is a work in progress - but I was looking at this and I'm curious how these grids here were chosen? Especially as the description of the PR seems to imply that we'll use directory names such as global.0p16 or arctic.9km?
@JessicaMeixner-NOAA Yes. I know. I was assigned this on Monday and I did some editing to start the PR. This is just for testing and get the idea what files need to be changed. Have to talk to Walter about this soon one I get the hang of it. Please ignore the first few commits I have made. Once I am ready will let you know for review.
There was a problem hiding this comment.
Sounds great @AntonMFernando-NOAA ! Let me know if there's anything I can help point out or explain for waves!
There was a problem hiding this comment.
@JessicaMeixner-NOAA Will do. Thank you .
jobs/JGLOBAL_ARCHIVE
Outdated
| for grid in "0p25" "0p50" "1p00"; do | ||
| YMD=${PDY} HH=${cyc} GRID=${grid} declare_from_tmpl -rx \ | ||
| "COMIN_WAVE_GRID_${grid}:COM_WAVE_GRID_RES_TMPL" |
There was a problem hiding this comment.
| for grid in "0p25" "0p50" "1p00"; do | |
| YMD=${PDY} HH=${cyc} GRID=${grid} declare_from_tmpl -rx \ | |
| "COMIN_WAVE_GRID_${grid}:COM_WAVE_GRID_RES_TMPL" | |
| for grdID in ${wavepostGRD} ${waveinterpGRD}; do | |
| case $grdID in | |
| glo_15mxt) GRDRES=0p25;; | |
| reg025) GRDRES=0p25;; | |
| glo_025) GRDRES=0p25;; | |
| glo_100) GRDRES=1p00;; | |
| glo_200) GRDRES=2p00;; | |
| glo_500) GRDRES=5p00;; | |
| glo_30mxt) GRDRES=0p50;; | |
| glo_30m) GRDRES=0p50;; | |
| at_10m) GRDRES=0p16;; | |
| ep_10m) GRDRES=0p16 ;; | |
| wc_10m) GRDRES=0p16;; | |
| ak_10m) GRDRES=0p16;; | |
| ant_9km) GRDRES=9km;; | |
| glo_10m) GRDRES=0p16;; | |
| gnh_10m) GRDRES=0p16;; | |
| gsh_15m) GRDRES=0p25;; | |
| glo_15m) GRDRES=0p25;; | |
| ao_20m) GRDRES=0p33;; | |
| so_20m) GRDRES=0p33;; | |
| gwes_30m) GRDRES=0p50;; | |
| esac | |
| YMD=${PDY} HH=${cyc} GRID=${GRDRES} declare_from_tmpl -rx \ | |
| "COMIN_WAVE_GRID_${grid}:COM_WAVE_GRID_RES_TMPL" |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ShellCheck found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Description
This pull request addresses the organization of wave gridded products within the file structure. Currently, all wave gridded products are placed in products/wave/gridded, without any further categorization. To align with the structure used by other component products (such as grib2), this update introduces a domain/resolution directory level to group output more effectively.
For example, instead of having all products in a single directory, the structure will now include specific directories based on domain and resolution (e.g., products/wave/gridded/arctic.9km, products/wave/gridded/global.0p16). This change improves organization and scalability for wave gridded product outputs.
Resolves Add domain level to wave gridded COM path #2677
Type of change
COM_WAVE_GRID_TMPLupdated (or a new template, similar toCOM_ATMOS_GRIB_TMPandCOM_ATMOS_GRIB_GRID_TMPL) to include a directory level for the domain and resolutionChange characteristics
How has this been tested?
Checklist