-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable traditional threading as an option #3149
Open
aerorahul
wants to merge
5
commits into
NOAA-EMC:develop
Choose a base branch
from
aerorahul:feature/traditional_threading
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable traditional threading as an option #3149
aerorahul
wants to merge
5
commits into
NOAA-EMC:develop
from
aerorahul:feature/traditional_threading
+95
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DusanJovic-NOAA
approved these changes
Dec 10, 2024
After some waiting for WW3 points, it seems the model progressed in the test on Hercules. The run will time out at 30 mins, because I was testing it. Still worth taking a look at the log. |
A run of the test C768_S2SW succeeded on Hercules with traditional threading. |
RuiyuSun
approved these changes
Dec 11, 2024
WalterKolczynski-NOAA
approved these changes
Dec 11, 2024
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
**CM use only** PR is ready for CI testing on Hera
label
Dec 11, 2024
emcbot
added
CI-Hera-Building
**Bot use only** CI testing is cloning/building on Hera
CI-Hera-Running
**Bot use only** CI testing on Hera for this PR is in-progress
and removed
CI-Hera-Ready
**CM use only** PR is ready for CI testing on Hera
CI-Hera-Building
**Bot use only** CI testing is cloning/building on Hera
labels
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a previous PR, stubs were added to enable traditional threading in the UFS.
This PR takes the next step to execute the model with traditional threading.
Specifically;
_esmf
ufs_configure
file for traditional threading. This sets theglobalResourceControl
tofalse
(traditional threading) ... this was done in the previous PRufs_configure
... this PRexport OMP_NUM_THREADS=$UFS_THREADS
... this was done in the previous PRThe default behaviour to use ESMF-managed threading is retained. Traditional threading can be achieved by toggling
USE_ESMF_THREADING
flag inconfig.fcst
Closes #3122 - as in allows the model to be configured to run w/ traditional threading. Testing on C768 S2SW was successful on Hercules (This was previously reported to be failing)
The use of traditional threading will be inefficient for model components that are not thread-enabled and supported e.g. MOM6 and CICE6, but since they require smaller number of tasks compared to ATM or WAV, the CPU 'waste' is not huge.
Type of change
Change characteristics
How has this been tested?
Testing on Hercules for a C768 S2SW case was run with traditional threading (4 threads)
Some particulars of the run are as follows:
Run directory:
/work/noaa/stmp/rmahajan/HERCULES/RUNDIRS/c768s2swtt/gfs.2019120300/gfsfcst.2019120300/fcst.2077795/
Run log:
/work2/noaa/stmp/rmahajan/RUNTESTS//COMROOT/c768s2swtt/logs/2019120300/gfs_fcst_seg0.log
Checklist