Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Refactor values, min, max, and estimated from the Parameter constructor #218

Closed
1 task done
Bai-Li-NOAA opened this issue Aug 22, 2022 · 1 comment · Fixed by #455
Closed
1 task done
Labels
kind: question Further information is requested P1 high priority task status: wishlist this will be moved to a later milestone
Milestone

Comments

@Bai-Li-NOAA
Copy link
Contributor

Refactor request

We could refactor the names from the lines 56-57 of the rcpp_interface_base.hpp to make them clearer. For example, from

Parameter(double value, double min, double max, bool estimated)
      : value(value), min(min), max(max), estimated(estimated) {}

to

Parameter(double value_m, double min_m, double max_m, bool estimated_m)
      : value(value_m), min(min_m), max(max_m), estimated(estimated_m) {}

@msupernaw suggests we refactor relevant code during the MQ stage.

Expected behavior

Use different names to distinguish values, min, max, and estimated from the Parameter constructor.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Bai-Li-NOAA Bai-Li-NOAA added the status: triage_needed This is not approved for this milestone, do not work on it yet label Aug 22, 2022
@ChristineStawitz-NOAA ChristineStawitz-NOAA added status: wishlist this will be moved to a later milestone and removed status: triage_needed This is not approved for this milestone, do not work on it yet labels Sep 7, 2022
@ChristineStawitz-NOAA ChristineStawitz-NOAA added this to the MQ milestone Sep 7, 2022
@Andrea-Havron-NOAA Andrea-Havron-NOAA added kind: question Further information is requested status: needs discussion Dialogue is needed before a decision can be made. labels Jul 7, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA moved this to Needs Discussion in MQ Jul 12, 2023
@Andrea-Havron-NOAA
Copy link
Collaborator

Related to Issue #411

@Andrea-Havron-NOAA Andrea-Havron-NOAA added FIMS workshop P1 high priority task labels Jul 18, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA moved this from Needs Discussion to Blocked in MQ Jul 31, 2023
@Andrea-Havron-NOAA Andrea-Havron-NOAA moved this from Blocked to FIMS Meeting in MQ Jul 31, 2023
@Bai-Li-NOAA Bai-Li-NOAA linked a pull request Aug 22, 2023 that will close this issue
1 task
@github-project-automation github-project-automation bot moved this from FIMS Meeting to Done in MQ Sep 21, 2023
@kellijohnson-NOAA kellijohnson-NOAA removed the status: needs discussion Dialogue is needed before a decision can be made. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: question Further information is requested P1 high priority task status: wishlist this will be moved to a later milestone
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants