Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: MakeADFun fails #247

Closed
1 task done
Bai-Li-NOAA opened this issue Oct 18, 2022 · 2 comments
Closed
1 task done

[Bug]: MakeADFun fails #247

Bai-Li-NOAA opened this issue Oct 18, 2022 · 2 comments
Labels
kind: bug Something isn't working
Milestone

Comments

@Bai-Li-NOAA
Copy link
Contributor

Describe the bug

All call-r-cmd-check GHA operations from a few feature branches failed. The operations were canceled on windows, macOS, ubuntu after running for a few hours.

The warning messages include:
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout

macOS-latest pipelines will use macOS-12 soon. For more details, see actions/runner-images#6384

Relevant issue from the ghactions4r package: nmfs-fish-tools/ghactions4r#46

To Reproduce

GHA logs can be found here and here.

Expected behavior

call-r-cmd-check GHA passes.

Screenshots

No response

Which OS are you seeing the problem on?

Windows, Mac, Linux

Which browser are you seeing the problem on?

No response

Which version of FIMS are you seeing the problem on?

No response

Additional Context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Bai-Li-NOAA Bai-Li-NOAA added the kind: bug Something isn't working label Oct 18, 2022
@Bai-Li-NOAA
Copy link
Contributor Author

Bai-Li-NOAA commented Oct 19, 2022

Thanks @k-doering-NOAA for updating GHA yml files in the ghactions4r package. A few failed GHA checks in FIMS work again after using updated workflows from ghactions4r.

However, the R-cmd-check from the 180-feat-population branch and other branches that are based on the population module branch still take over 6 hours to run and fail to run after checking examples.

The error relates to examples from the io.R file. After using \dontrun for the example in the io.R file, the r-cmd-check workflow works again (see working workflows here). Maybe we can 

  • pull the changes from the bug-r-cmd-check-population-modules to 180-feat-population to allow r-cmd-check checks other things (e.g., code compilation and tests for other R functions).

  • then create a new yml file to run mkObj() only to remind us that we need to figure out why MakeADFun does not work.

@k-doering-NOAA
Copy link
Member

@Bai-Li-NOAA I think this was solved?

@ChristineStawitz-NOAA ChristineStawitz-NOAA changed the title [Bug]: call-r-cmd-check GHA failed [Bug]: MakeADFun fails Dec 6, 2022
@ChristineStawitz-NOAA ChristineStawitz-NOAA closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants