-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the directory mosaic #1344
Comments
@mlee03 That read_mosaic.c file is causing some issues for removing the macros. I was thinking it should've been ifdef'ed with fms/mpp_io as it somewhat qualifies as "old io" and uses netcdf calls directly, does that sound good to you? We shouldn't need these io routines now since fms2_io is flawless and works as intended lol, but we've seen with create_xgrid sometimes C functions can sneak in and be used in other files without a use or anything. We should probably bind the C functions used to a fortran routine as part of these updates. |
lol @rem1776 I was thinking of removing all functions in there except for |
@rem1776 sounds good! |
Is your feature request related to a problem? Please describe.
There are two mosaic related directories in FMS: mosaic2 and mosaic. Currently,
mosaic2_mod
andgrid2_mod
in mosaic2 are being utilized whilemosaic_mod
andgrid_mod
in mosaic have been retired. Thus the directory mosaic can/should be removed. However, the mosaic directory cannot be removed because it also contains ".c" files that are being used by mosaic2 and horiz_interp.This issue suggests to
mosaic
tomosaic2
directorymosaic
directoryDescribe alternatives you've considered
Leave it as it is.
Additional context
Striving to make FMS more perfect.
The text was updated successfully, but these errors were encountered: