Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with Redis license changing #639

Open
2 of 3 tasks
robertbartel opened this issue May 29, 2024 · 2 comments
Open
2 of 3 tasks

Deal with Redis license changing #639

robertbartel opened this issue May 29, 2024 · 2 comments
Labels
community The issue was opened as a result of some kind of feedback received from outside of OWP dependencies Pull requests that update a dependency file maas MaaS Workstream

Comments

@robertbartel
Copy link
Contributor

robertbartel commented May 29, 2024

As discussed here (and actually executed here), Redis has changed their licensing to no longer be open source in newer versions. Opening this for deliberate tracking of subtasks to ensure DMOD remains functional, open, and license-compliant following this.

One thing worth noting at this level is that, as of this writing, the official Redis Docker image page on Dockerhub does still refer to Redis as being open source. Likely not by accident, the latest version for images is 7.2.5, which is before the licensing change (7.4).

@robertbartel robertbartel added dependencies Pull requests that update a dependency file maas MaaS Workstream community The issue was opened as a result of some kind of feedback received from outside of OWP labels May 29, 2024
@christophertubbs
Copy link
Contributor

Took a look at Valkey. It should not only be a drop in replacement, but a deployment decision. It's a fork from before Redis decided to put new fancy stuff, like TimeSeries within their Redis Stack product. The python client for it is... wait for it... redis-py. i.e., what we already use. If we want a new version of Redis to solve CVEs or something, we just swap the image in the docker-compose files to that of the latest acceptable version of valkey. No problemo.

@robertbartel
Copy link
Contributor Author

Thanks, @christophertubbs. This looks perfect. We'll go in this direction when we are ready (or are otherwise forced) to move off the current Redis image. I don't think anything compels us to do that ASAP, though I also won't argue if this gets done sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community The issue was opened as a result of some kind of feedback received from outside of OWP dependencies Pull requests that update a dependency file maas MaaS Workstream
Projects
None yet
Development

No branches or pull requests

2 participants