Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indices to associate with hydrofabric to DataFormats that involve CATCHMENT_ID #659

Open
robertbartel opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working maas MaaS Workstream

Comments

@robertbartel
Copy link
Contributor

Any DataFormat instances that use StandardDatasetIndex.CATCHMENT_ID, and any associated DataDomains and Datasets, must be related to some particular hydrofabric. At present, this is not represented by format or domain definitions, but this needs to be corrected.

E.g., a forcing dataset can be constrained to a certain set of catchments by its DataDomain to indicate it only covers those catchments. The true catchments being referenced by the constraint - i.e., to which the forcing data is actually applicable - may only exist in the hydrofabric dataset used to regrid the original gridded data. A domain definition, if constrained by catchments, is thus incomplete unless we also explicitly constrain the domain to the hydrofabric in which those catchment exist.

@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
Development

No branches or pull requests

1 participant