Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more object types in the DataLoopNode::ConnectionObjectType #10204

Closed
3 tasks
lgu1234 opened this issue Sep 6, 2023 · 0 comments · Fixed by #10388
Closed
3 tasks

Add more object types in the DataLoopNode::ConnectionObjectType #10204

lgu1234 opened this issue Sep 6, 2023 · 0 comments · Fixed by #10388
Assignees

Comments

@lgu1234
Copy link
Contributor

lgu1234 commented Sep 6, 2023

Issue overview

The NodeInputManager::GetOnlySingleNode function is used to get a node number. One of requirements is to provide DataLoopNode::ConnectionObjectType. The current list of ConnectionObjectType may not cover all possible object types, such as AirLoopHVAC:Splitter and AirLoopHVAC:Mixer. These two objects may be needed in the list, so that the GetOnlySingleNode can be used to get node numbers defined in these two objects.

This issue was raised after review of PR #10042

Details

Some additional details for this issue (if relevant):

  • Platform (Operating system, version)
  • Version of EnergyPlus (if using an intermediate build, include SHA)
  • Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant