Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI tests to ensure each CPP macro condition works #8377

Closed
3 tasks
JasonGlazer opened this issue Nov 12, 2020 · 2 comments
Closed
3 tasks

Add CI tests to ensure each CPP macro condition works #8377

JasonGlazer opened this issue Nov 12, 2020 · 2 comments
Assignees
Labels
Defect Includes code to repair a defect in EnergyPlus

Comments

@JasonGlazer
Copy link
Contributor

Issue overview

It might be good to add some CI tests to compile with other than the default set of switches for the CPP macros to ensure that code change continue to work. I recently tried compiling with EP_cache_PsyTsatFnPb not defined and EnergyPlus does not compile. This may also exist for other of the CPP macros.

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Defect file added (list location of defect file here)
  • Ticket added to Pivotal for defect (development team task)
  • Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)
@JasonGlazer
Copy link
Contributor Author

@Myoldmopar and @mitchute should this issue still be open? I thought that the alternate build configurations handled this.

@mitchute
Copy link
Collaborator

I think we can close it. #8521 is one example of how this has been addressed, but there are others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

No branches or pull requests

2 participants