Indoor green update 2 #10734
Merged
Indoor green update 2 #10734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Indeed the results are all happy when this is run from within the NREL/EnergyPlus repo. Something is acting up when an external PR is trying to POST a comment to a PR on the NREL/EnergyPlus repo. Anyway, this is good to go in. Thanks @LipingWang. This will bring in the changes from #10731, so I'll close that now. Not sure what's up with #10737 yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual code changes are documented in #10731. I am trying something though. In that PR, the GitHub Action failed to POST a comment on the PR about regressions. I assume it is something about permissions as this contribution is coming from an outside fork, but I actually can't see what we would need to add to fix it. For now I'm pushing the branch here and will see what happens when it comes from a branch on the upstream repo itself. I expect this will work here for now, and I'll merge this one and close #10731 (your commits are still included in this branch @LipingWang ). And then sometime after release I'll figure out the forking issue.