Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAT run fails due to mongo validation, starts E+ over and over again #245

Closed
rHorsey opened this issue Jan 4, 2018 · 6 comments
Closed
Assignees
Labels

Comments

@rHorsey
Copy link
Contributor

rHorsey commented Jan 4, 2018

From @jmarrec on June 26, 2017 14:17

I'm running into an issue where PAT apparently fails to validate a datapoint, will then relaunch the E+ simulation, etc etc.

See the log retrieved from /temp_data/analysis_593fcac3-d036-435c-b089-76406ee383b8/data_point_8a8cda99-907b-49eb-b676-541ce40d593f/.

In real time I could just see energyplus completing, then starting again...

8a8cda99-907b-49eb-b676-541ce40d593f.txt

An extract:

[15:58:44.647862 INFO] Opening run.log file '/Users/julien/Desktop/Kristof/PAT-Analysis/temp_data/analysis_593fcac3-d036-435c-b089-76406ee383b8/data_point_8a8cda99-907b-49eb-b676-541ce40d593f/run/run.log'
[15:58:44.663598 INFO] Running workflow
[16:11:40.225241 INFO] Final run state is finished
[16:11:40.250054 ERROR] /Applications/OpenStudio-2.1.2/ParametricAnalysisTool.app/Contents/Resources/OpenStudio-server/server/app/workers/run_simulate_data_point.rb failed with The dotted field 'All Facades - Replaced Only - 44.2-16Argon-4Low-E' in 'results.All Facades - Replaced Only - 44.2-16Argon-4Low-E' is not valid for storage. (57), /Applications/OpenStudio-2.1.2/ParametricAnalysisTool.app/Contents/Resources/OpenStudio-server/gems/gems/mongo-2.4.2/lib/mongo/operation/result.rb:256:in `validate!'

Pretty sure that's because the name this design alternative includes a .. I have 4 design alternatives that use the 44.2 window type, and these are the only ones that will not run.

MongoDB cannot work when there are dots present in the key apparently.

This should be sanitized...

Copied from original issue: NREL/OpenStudio#2673

@rHorsey
Copy link
Contributor Author

rHorsey commented Jan 4, 2018

From @jmarrec on June 26, 2017 14:36

Confirmed, removing the . in the measure option allows me to run the design alternatives that use them successfully

@rHorsey
Copy link
Contributor Author

rHorsey commented Jan 4, 2018

@kflemin and @nllong Where is the preferred sanitation point in your opinions: PAT, or the model import pipeline?

@rHorsey
Copy link
Contributor Author

rHorsey commented Jan 4, 2018

From @nllong on June 28, 2017 14:28

model import

@rHorsey
Copy link
Contributor Author

rHorsey commented Jan 4, 2018

We apparently should ascii character code the restricted mongo characters.

@rHorsey
Copy link
Contributor Author

rHorsey commented Jan 4, 2018

From @ljbrackney on September 12, 2017 18:6

Is this going to be fixed before release? I just stubbed my toe on the issue myself.

@rHorsey
Copy link
Contributor Author

rHorsey commented Jan 4, 2018

From @kflemin on September 12, 2017 19:56

I just added a check in PAT after the 'run entire workflow' button is pushed. I'm checking for these characters: $.€£ in both option names and design alternative names. At some point we'll want to implement a more complete solution server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants