Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacked area on left Y axis gets re-checked after every simulation #1986

Open
brtietz opened this issue Dec 20, 2024 · 3 comments · May be fixed by #1987
Open

Stacked area on left Y axis gets re-checked after every simulation #1986

brtietz opened this issue Dec 20, 2024 · 3 comments · May be fixed by #1987
Assignees
@mjprilliman
Labels
bug
Milestone
2024 Release Patch 1

Comments

@brtietz
Copy link
Collaborator

brtietz commented Dec 20, 2024

Describe the bug

The new PV-battery default graphs attempt to re-assert themselves after every simulation run, even after initial graphics have been set up.

To Reproduce

Steps to reproduce the behavior:

  1. Create a PV-Battery behind-the-meter case
  2. Click simulate
  3. Change the graphs and uncheck "stacked area on left Y axis"
  4. Click simulate and go back to graphs
  5. Stacked area on left Y axis is checked again

Expected behavior

Time series graphs settings shouldn't change when the user hits simulate

Operating System and Version

  • Version: 2024.12.12
@brtietz brtietz added the bug label Dec 20, 2024
@brtietz brtietz added this to the 2024 Release Patch 1 milestone Dec 20, 2024
@mjprilliman
Copy link
Collaborator

In my testing, this was only the case when nothing is selected on Time Series graphs, similar to how gen populates when nothing is selected. I'm not opposed to changing the behavior, but that is how it's supposed to work now.

@brtietz
Copy link
Collaborator Author

brtietz commented Dec 20, 2024

That hasn't been my experience today - maybe something change late in the process? Here are screenshots of an example. Before pressing simulate:

image

After:

image

If you're having trouble reproducing it I can send over a SAM file that's giving me issues. If it makes a difference it was upgraded from the previous version of SAM.

@mjprilliman
Copy link
Collaborator

Need to move max window sizing within the check for variables selected.

@mjprilliman mjprilliman linked a pull request Dec 20, 2024 that will close this issue
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjprilliman mjprilliman

Labels
bug
Projects
None yet
Milestone
2024 Release Patch 1
Development

Successfully merging a pull request may close this issue.

Move stacked area check and window sizing in check for any variables NREL/SAM
2 participants
@brtietz @mjprilliman