Replies: 2 comments 1 reply
-
This strikes me as a good idea, @ejsimley if you agree I say we add this is as an issue. We could then further discuss if this is a v2 target or future work |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Many of the notebooks in the examples contain functions. I believe that many users, including ourselves, are simply copying the examples so that we can use the functions. Should these functions actually be part of the source code? That would:
The counterargument, I suppose, is that if the functions defined in the examples are too tied to the SCADA record, we shouldn't generalize them.
A good example of this is in examples_artificial_data/01_raw_data_processing/01_northing_calibration.ipynb. It feels like the following functions could all be moved to the source code:
get_bias_for_single_turbine()
estimate_bias_with_reference_wd()
apply_bias_corrections()
filter_for_faults_in_impacting_turbines()
Beta Was this translation helpful? Give feedback.
All reactions