Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Re-organize FLASC examples slightly #113

Closed
paulf81 opened this issue Aug 22, 2023 · 2 comments
Closed

[Feature]: Re-organize FLASC examples slightly #113

paulf81 opened this issue Aug 22, 2023 · 2 comments
Assignees
@paulf81 @misi9170 @ejsimley
Labels
enhancement An improvement of an existing feature
Milestone
v1.4

Comments

@paulf81
Copy link
Collaborator

paulf81 commented Aug 22, 2023

Description

FLASC examples are currently into root-level folders examples_artificial_data and examples_smarteole, but then also some files needed for these examples are within flasc/examples, which breaks a bit the convention of the self-contained examples folder in floris. Propose to re-organize a little bit for clarity.

Smaller point might be to number the notebooks in examples_artificial_data to clarify which should be run first

Related URLs

No response
@paulf81 paulf81 added the enhancement An improvement of an existing feature label Aug 22, 2023
@paulf81 paulf81 added this to the v1.4 milestone Aug 22, 2023
@misi9170 misi9170 mentioned this issue Aug 31, 2023
Merged
@misi9170
Copy link
Collaborator

Addressed in #117

1 similar comment
@paulf81
Copy link
Collaborator Author

paulf81 commented Aug 31, 2023

Addressed in #117

@paulf81 paulf81 closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulf81 paulf81

@misi9170 misi9170

@ejsimley ejsimley

Labels
enhancement An improvement of an existing feature
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@paulf81 @misi9170 @ejsimley