Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Model Estimation and Model Tuning modules seem similar #144

Closed
1 task done
paulf81 opened this issue Dec 7, 2023 · 4 comments
Closed
1 task done

[BUG] Model Estimation and Model Tuning modules seem similar #144

paulf81 opened this issue Dec 7, 2023 · 4 comments
Labels
enhancement An improvement of an existing feature v2.0
Milestone

Comments

@paulf81
Copy link
Collaborator

paulf81 commented Dec 7, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Model estimation and model tuning modules in FLASC have different functionality, but are notionally related, should probably be harmonized into one module in the future

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- pip environment (can be retrieved with `pip list`):

Anything else?

No response

@misi9170
Copy link
Collaborator

misi9170 commented Dec 8, 2023

Agreed, we could use some alignment here, possibly as part of a larger restructuring. Another one to toss in as relevant, but in a separate location yaw_pow_fitting.py

@paulf81
Copy link
Collaborator Author

paulf81 commented Dec 8, 2023

Yeah, seems like these could all be combined into one cohesive module as an upcoming activity

@paulf81 paulf81 added enhancement An improvement of an existing feature v2.0 labels Dec 12, 2023
@Bartdoekemeijer
Copy link
Collaborator

Sounds like a great idea!

@paulf81 paulf81 added this to the v2.0 milestone Jan 31, 2024
@misi9170
Copy link
Collaborator

Addressed in #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature v2.0
Projects
None yet
Development

No branches or pull requests

3 participants