Architecture improvements #463
rafmudaf
started this conversation in
v3 Design Discussion
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Areas in FLORIS v3 where the architecture is poorly defined or less thought out.
Heterogenous turbine
To support various turbine definitions,
Farm
goes through a few methods to map turbine definition properties to the corresponding index in the array structures. This works, but it seems clunky and it's easy to break if these functions aren't run when they need to be.Input clarity
There are places where the inputs to a class are immediately modified into something else other than what is specified in the attrs definition. For example, the Farm class takes a turbine-type list and it is initialized through the attires functionality. If you give one turbine definition, this list is length 1. In the post init, the same variable is expanded to length n turbines. Is it more clear to have the API for this class state this up front?
Beta Was this translation helpful? Give feedback.
All reactions