Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximum call stack size exceeded with some settings #493

Closed
thib3113 opened this issue Mar 4, 2022 · 4 comments · May be fixed by snyk-omar/snyk-juice-shop#106, antz-snyk1/juice-shop-alexei#5, JonChiAppRisk/juice-shop-goof#7, slatersnyk/juice-shop#676 or fanibahar/juice-shop1#69
Closed

Maximum call stack size exceeded with some settings #493

thib3113 opened this issue Mar 4, 2022 · 4 comments · May be fixed by snyk-omar/snyk-juice-shop#106, antz-snyk1/juice-shop-alexei#5, JonChiAppRisk/juice-shop-goof#7, slatersnyk/juice-shop#676 or fanibahar/juice-shop1#69
Assignees
@mashpie
Labels
bug

Comments

@thib3113
Copy link

thib3113 commented Mar 4, 2022

I think I found a bug,
I'm using version 0.14.1 .

I'm using the options :

retryInDefaultLocale = true;
syncFiles: true,

So when I translate :

  • i18nTranslate => call translate
  • translate see (!skipSyncToAllFiles && syncFiles) === true => call syncToAllFiles
  • syncToAllFiles => call translate with skipSyncToAllFiles = true
  • translate go to here (same here) => call translate file without skipSyncToAllFiles
  • translate see (!skipSyncToAllFiles && syncFiles) === true => call syncToAllFiles (and then, restart the loop) .

Maybe passing syncToAllFiles here and here, can be a quick fix
@mashpie
Copy link
Owner

mashpie commented Mar 4, 2022

would you be able to setup a minimal reproduction repository?

@thib3113
Copy link
Author

thib3113 commented Mar 4, 2022 •
edited
Loading

@mashpie here is it : https://github.com/thib3113/i18n-493-issue .

But, it's mostly :

const { I18n } = require("i18n");
const path = require("path");

const i18n = new I18n({
    locales: ["en", "de"],
    directory: path.join(__dirname, "locales"),
    defaultLocale: "en",
    retryInDefaultLocale: true,
    syncFiles: true,
});

i18n.__("test");

Setting syncFiles and retryInDefaultLocale in the same times that produce the bug .

@mashpie mashpie self-assigned this Mar 4, 2022
@mashpie
Copy link
Owner

mashpie commented Mar 4, 2022

Thanks, will look into it over weekend probably

@mashpie mashpie added the bug label Mar 5, 2022
@mashpie mashpie closed this as completed in 1d956f3 Mar 5, 2022
@mashpie
Copy link
Owner

mashpie commented Mar 5, 2022

Thank you @thib3113 for reporting and analysing. Your guess for a fix was also perfectly right. I've just added tests to cover your issue.

A new version 0.14.2 should be released within minutes

@snyk-omar snyk-omar mentioned this issue Oct 22, 2022
Open
@antz-snyk antz-snyk mentioned this issue Sep 30, 2023
Open
@jonathanchisnyk jonathanchisnyk mentioned this issue Mar 29, 2024
Open
@slatersnyk slatersnyk mentioned this issue May 25, 2024
Open
@fanibahar fanibahar mentioned this issue May 25, 2024
Open
@cooldev-200 cooldev-200 mentioned this issue May 26, 2024
Open
@worstyrite worstyrite mentioned this issue May 26, 2024
Open
@denk247 denk247 mentioned this issue May 31, 2024
Open
@yangpulse-snyk yangpulse-snyk mentioned this issue Jun 2, 2024
Open
@ZolotarenkoDan ZolotarenkoDan mentioned this issue Jun 7, 2024
Open
@kostatuno kostatuno mentioned this issue Jun 8, 2024
Closed
@cicdpipeline1 cicdpipeline1 mentioned this issue Jun 9, 2024
Open
@valentina-creator valentina-creator mentioned this issue Jun 9, 2024
Open
@harinee harinee mentioned this issue Jun 13, 2024
Closed
@arunkp arunkp mentioned this issue Jun 15, 2024
Open
@ShishiraKashyap ShishiraKashyap mentioned this issue Jun 15, 2024
Open
@bkiranraj bkiranraj mentioned this issue Jun 15, 2024
Open
@Suas1901 Suas1901 mentioned this issue Jun 15, 2024
Open
@AmoghGowda AmoghGowda mentioned this issue Jun 16, 2024
Open
@KrissWorks KrissWorks mentioned this issue Jun 16, 2024
Open
@vinaychandranac vinaychandranac mentioned this issue Jun 16, 2024
Open
@grimmgit grimmgit mentioned this issue Jun 21, 2024
Open
@NadavSha1 NadavSha1 mentioned this issue Jun 21, 2024
Open
@GarrettNutting GarrettNutting mentioned this issue Oct 24, 2024
Open
@Dayhta Dayhta mentioned this issue Oct 24, 2024
Open
@abensaid-ext abensaid-ext mentioned this issue Oct 24, 2024
Open
@MarcusPlexus MarcusPlexus mentioned this issue Oct 25, 2024
Open
@mrhawaii05 mrhawaii05 mentioned this issue Oct 26, 2024
Open
@riparino riparino mentioned this issue Oct 28, 2024
Closed
@likhita-singla-sada likhita-singla-sada mentioned this issue Oct 29, 2024
Open
@mariozerillo mariozerillo mentioned this issue Oct 30, 2024
Open
@MimiDas-Snyk MimiDas-Snyk mentioned this issue Oct 31, 2024
Open
@manishchh manishchh mentioned this issue Nov 1, 2024
Open
@SwethaPolanki05 SwethaPolanki05 mentioned this issue Nov 1, 2024
Open
@aanchalHkd aanchalHkd mentioned this issue Nov 1, 2024
Open
@pynetx pynetx mentioned this issue Nov 1, 2024
Open
@vinnimous vinnimous mentioned this issue Nov 1, 2024
Open
@samck8s samck8s mentioned this issue Nov 1, 2024
Open
@nchoe-deloitte nchoe-deloitte mentioned this issue Nov 1, 2024
Open
@rbeal1227 rbeal1227 mentioned this issue Nov 1, 2024
Open
@nekwonnah nekwonnah mentioned this issue Nov 1, 2024
Open
@NSara11 NSara11 mentioned this issue Nov 1, 2024
Open
@celelel celelel mentioned this issue Nov 2, 2024
Open
@Kakarott-SS Kakarott-SS mentioned this issue Nov 2, 2024
Open
@DefenderK DefenderK mentioned this issue Nov 3, 2024
Open
@kciesielski kciesielski mentioned this issue Nov 5, 2024
Open
@PriceUnknown PriceUnknown mentioned this issue Nov 5, 2024
Open
@khoji-stack khoji-stack mentioned this issue Nov 6, 2024
Open
@Sangram99-hacker Sangram99-hacker mentioned this issue Nov 7, 2024
Open
@Uachootitan Uachootitan mentioned this issue Nov 10, 2024
Open
@sindhuhack sindhuhack mentioned this issue Nov 10, 2024
Open
@rickhull0508 rickhull0508 mentioned this issue Nov 10, 2024
Open
@snykNR snykNR mentioned this issue Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mashpie mashpie

Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@mashpie @thib3113