Allow for random IO workloads via fio - default to sequential #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roclark
approved these changes
Apr 8, 2021
bobber/lib/tests/run_tests.py
Outdated
Comment on lines
86
to
87
| f'read_pattern_{args.read_pattern}_' | ||
| f'write_pattern_{args.read_pattern}_' |
There was a problem hiding this comment.
This doesn't change anything with our parser, correct? I don't think it should as it shouldn't expect a rigid structure for the log's filename, but something I'd want to double check.
There was a problem hiding this comment.
Still need to test - worst case, will try to test locally on my Mac.
There was a problem hiding this comment.
Let me know if you want me to run on my workstation and I can test it out too.
joehandzik
force-pushed
the
wip-add-io-patterns
branch
2 times, most recently
from
faf953e to
477b218
Compare
joehandzik
force-pushed
the
wip-add-io-patterns
branch
3 times, most recently
from
363fff6 to
55587ff
Compare
|
Updated read-pattern argument to random in the CI test - this lets us test the default and the alternate argument between reads and writes in the same test sweep. If this passes CI, I am comfortable merging it. |
joehandzik
force-pushed
the
wip-add-io-patterns
branch
3 times, most recently
from
62c93f6 to
988cecc
Compare
Signed-Off-By: Joe Handzik <jhandzik@nvidia.com>
joehandzik
force-pushed
the
wip-add-io-patterns
branch
from
988cecc to
05c046b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Joe Handzik jhandzik@nvidia.com