Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded "text" column in _run_classifier_helper function #333

Open
sarahyurick opened this issue Oct 29, 2024 · 0 comments · May be fixed by #334
Open

Remove hardcoded "text" column in _run_classifier_helper function #333

sarahyurick opened this issue Oct 29, 2024 · 0 comments · May be fixed by #334
Assignees

Comments

@sarahyurick
Copy link
Collaborator

Our domain, quality, AEGIS, and FineWeb-Edu classifier CLI scripts all accept the --input-text-field parameter but do not use it. Currently, we hardcode these classifiers to use only be able to run on a column called "text", see here.

We need to modify _run_classifier_helper and all subsequent functions to accept a text column.

@sarahyurick sarahyurick self-assigned this Oct 29, 2024
@sarahyurick sarahyurick linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant