Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Nemotron in Nemo-UX #10138

Merged
merged 13 commits into from
Aug 22, 2024
Merged

[Draft] Nemotron in Nemo-UX #10138

merged 13 commits into from
Aug 22, 2024

Conversation

suiyoubi
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

suiyoubi and others added 2 commits August 15, 2024 07:28
Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
suiyoubi and others added 2 commits August 15, 2024 09:04
Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
@suiyoubi suiyoubi requested a review from ahmadki August 15, 2024 16:07
@ahmadki ahmadki removed their request for review August 15, 2024 16:07
nemo/collections/llm/gpt/model/nemotron.py Outdated Show resolved Hide resolved
nemo/collections/llm/gpt/model/nemotron.py Outdated Show resolved Hide resolved
nemo/collections/llm/gpt/model/nemotron.py Outdated Show resolved Hide resolved
nemo/collections/llm/gpt/model/nemotron.py Outdated Show resolved Hide resolved
nemo/collections/llm/gpt/model/nemotron.py Show resolved Hide resolved
nemo/collections/llm/gpt/model/nemotron.py Show resolved Hide resolved
ahmadki
ahmadki previously approved these changes Aug 19, 2024
@suiyoubi suiyoubi merged commit 08cddbf into main Aug 22, 2024
129 of 130 checks passed
@suiyoubi suiyoubi deleted the aot/nemo-ux-nemotron branch August 22, 2024 14:11
WoodieDudy pushed a commit to WoodieDudy/NeMo that referenced this pull request Aug 26, 2024
* add nemotron

* add nemotron exporter. make converted model identical

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* add more config

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* add config

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* import refactor

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* refactor config

* add 22B config

---------

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com>
hemildesai pushed a commit that referenced this pull request Aug 28, 2024
* add nemotron

* add nemotron exporter. make converted model identical

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* add more config

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* add config

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* import refactor

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* refactor config

* add 22B config

---------

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com>
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
* add nemotron

* add nemotron exporter. make converted model identical

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* add more config

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* add config

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* import refactor

* Apply isort and black reformatting

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>

* refactor config

* add 22B config

---------

Signed-off-by: suiyoubi <suiyoubi@users.noreply.github.com>
Co-authored-by: suiyoubi <suiyoubi@users.noreply.github.com>
Signed-off-by: adityavavre <aditya.vavre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants