Remove duplicated _format_env_vars calls #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaekyungHeo
requested review from
amaslenn,
artemry-nv,
srivatsankrishnan and
srinivas212
TaekyungHeo
force-pushed
the
rm-_format_env_vars-calls
branch
from
937f056
to
b368ea6
Compare
TaekyungHeo
force-pushed
the
rm-_format_env_vars-calls
branch
from
b368ea6
to
8c15cc4
Compare
amaslenn
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove duplicated _format_env_vars calls. The _format_env_vars function is called in every test template's gen_exec_command, which is redundant. This PR eliminates the function calls within each template and moves the _format_env_vars call to the parent class.
Test Plan
CI passes