Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retrieve for new map/multimap #643

Open
wants to merge 37 commits into
base: dev
Choose a base branch
from
Open

Add retrieve for new map/multimap #643

wants to merge 37 commits into from

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Nov 20, 2024 •
edited
Loading

This PR introduces retrieve APIs for map and multimap, while also removing the outdated and odd pair_count/retrieve tests.

PointKernel and others added 30 commits October 28, 2024 11:57
@PointKernel
Refactor set retrieve to use the new block-wise algorithm
e4aa0d7
@PointKernel
Merge remote-tracking branch 'upstream/dev' into improve-retrieve
673b6e6
@PointKernel
Remove redundant
86ee913
@PointKernel
Add set retrieve bench
ec3cff9
@PointKernel
Merge remote-tracking branch 'upstream/dev' into improve-retrieve
962174e
@PointKernel
Add early exit for single set/map retrieve
7b4b3fc
@PointKernel
Renaming for clarity + minor cleanups
d6dd669
@PointKernel
Reordering APIs
8d5bf12
@PointKernel
Improvement
be3f83d
@PointKernel
try launch bound
d51933f
@PointKernel
Merge remote-tracking branch 'upstream/dev' into improve-retrieve
0e3d874
@PointKernel
Update set retrieve bench
235963d
@PointKernel
Improve multiset retrieve test
5db1066
@PointKernel
Improve OA retrieve implementations
edd129e
@PointKernel
Add comments
f2aef9b
@PointKernel
Remove deprecated code
174940e
@PointKernel
Minor cleanups
a7a2c43
@PointKernel
Update include/cuco/detail/static_set/static_set.inl
f898d2e
@pre-commit-ci
[pre-commit.ci] auto code formatting
c325a6b
@PointKernel
Minor cleanups
394a74a
@PointKernel
Merge remote-tracking branch 'origin/improve-retrieve' into improve-r…
412205b 
…etrieve
@PointKernel @sleeepyjack
Apply suggestions from code review
5dc50ec 
Co-authored-by: Daniel Jünger <djuenger@nvidia.com>
@PointKernel
Merge remote-tracking branch 'upstream/dev' into improve-retrieve
9133ee8
@PointKernel
Merge remote-tracking branch 'origin/improve-retrieve' into improve-r…
bc601e1 
…etrieve
@PointKernel
Minor cleanup
703da6a
@PointKernel
Add host retrieve APIs for maps
ed86ac5
@PointKernel
Add device retrieve for maps
0117282
@PointKernel
Remove outdated set retrieve
f8c3dc4
@PointKernel
Remove outdated pair function test
609ee48
@PointKernel
Migrate multimap multiplicity test to test the new multimap
553018d
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 20, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@PointKernel PointKernel added type: feature request New feature request topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap labels Nov 20, 2024
@PointKernel PointKernel marked this pull request as ready for review November 21, 2024 19:04
@PointKernel
Copy link
Member Author

/ok to test

@PointKernel PointKernel added the Needs Review Awaiting reviews before merging label Nov 22, 2024
@PointKernel
Copy link
Member Author

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleeepyjack sleeepyjack Awaiting requested review from sleeepyjack sleeepyjack is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs Review Awaiting reviews before merging topic: static_map Issue related to the static_map topic: static_multimap Issue related to the static_multimap type: feature request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PointKernel