Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why DCGM_FI_DEV_PCIE_{TX,RX}_THROUGHPUT is default instead of DCGM_FI_PROF_PCIE_{TX,RX}_BYTES ? #354

Closed
koshieguchi opened this issue Jul 7, 2024 · 2 comments · Fixed by #357
Labels
question Further information is requested

Comments

@koshieguchi
Copy link
Contributor

koshieguchi commented Jul 7, 2024

I find it very confusing that DCGM_FI_DEV_PCIE_TX_THROUGHPUT is still marked as default in files like ./etc/default-counters.csv, despite the following statement in the DCGM Documentation (Version 3.3):

https://docs.nvidia.com/datacenter/dcgm/latest/dcgm-api/dcgm-api-field-ids.html#c.DCGM_FI_DEV_PCIE_TX_THROUGHPUT

DCGM_FI_DEV_PCIE_TX_THROUGHPUT200¶
PCIe Tx utilization information.
Deprecated: Use DCGM_FI_PROF_PCIE_TX_BYTES instead.

In fact, as mentioned in Get DCGM_FI_DEV_PCIE_TX_THROUGHPUT metric failed · Issue #167 · NVIDIA/dcgm-exporter, I was able to obtain PCIe data by changing DCGM_FI_DEV_PCIE_TX_THROUGHPUT to DCGM_FI_PROF_PCIE_TX_BYTES.

Is there a reason why DCGM_FI_DEV_PCIE_TX_THROUGHPUT hasn't been updated to DCGM_FI_PROF_PCIE_TX_BYTES in the CSV files under ./etc?

If it would be better to change it, I can create a pull request.

@koshieguchi koshieguchi added the question Further information is requested label Jul 7, 2024
@koshieguchi koshieguchi changed the title Why DCGM_FI_DEV_PCIE_{TX,RX}_THROUGHPUT is default? Why DCGM_FI_DEV_PCIE_{TX,RX}_THROUGHPUT is default instead of DCGM_FI_PROF_PCIE_{TX,RX}_BYTES ? Jul 7, 2024
@glowkey
Copy link
Collaborator

glowkey commented Jul 8, 2024

Thanks for reporting this. We are planning to update the default watchlist for the next major release of DCGM-Exporter in the coming months and this change is included. Feel free to create an MR in the meantime if that is helpful for your site.

@koshieguchi
Copy link
Contributor Author

Thanks for the reply!

We are planning to update the default watchlist for the next major release of DCGM-Exporter in the coming months and this change is included.

That's good to hear!

Feel free to create an MR in the meantime if that is helpful for your site.

I've created #357 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants